Bug 42760

Summary: [Chromium]: Crash during find-in-page
Product: WebKit Reporter: Finnur Thorarinsson <finnur.webkit>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Proposed fix
none
Added to the description in the changelog none

Description Finnur Thorarinsson 2010-07-21 09:24:10 PDT
Originally reported here:
http://code.google.com/p/chromium/issues/detail?id=46019

Turns out our users are seeing occasional crashes while searching, probably when search is still ongoing while the tab is closed/browser shutdown, although we haven't been able to repro. But I have a patch for this; will submit shortly.
Comment 1 Finnur Thorarinsson 2010-07-21 09:24:44 PDT
Call stack when it crashes:

0x6cf673c6	 [chrome.dll	 - scrollview.cpp:207]	WebCore::ScrollView::visibleContentRect(bool)
0x6cf66f6c	 [chrome.dll	 - scrollview.h:126]	WebCore::ScrollView::visibleWidth()
0x6d16ad77	 [chrome.dll	 - webframeimpl.cpp:558]	WebKit::WebFrameImpl::hasVisibleContent()
0x6d16dedb	 [chrome.dll	 - webframeimpl.cpp:2054]	WebKit::WebFrameImpl::shouldScopeMatches(WebCore::String const &)
0x6d16c9ed	 [chrome.dll	 - webframeimpl.cpp:1403]	WebKit::WebFrameImpl::scopeStringMatches(int,WebKit::WebString const &,WebKit::WebFindOptions const &,bool)
0x6d16e00d	 [chrome.dll	 - webframeimpl.cpp:2087]	WebKit::WebFrameImpl::callScopeStringMatches(WebKit::WebFrameImpl::DeferredScopeStringMatches *,int,WebKit::WebString const &,WebKit::WebFindOptions const &,bool)
0x6d16a9ac	 [chrome.dll	 - webframeimpl.cpp:431]	WebKit::WebFrameImpl::DeferredScopeStringMatches::doTimeout(WebCore::Timer<WebKit::WebFrameImpl::DeferredScopeStringMatches> *)
0x6cf66d84	 [chrome.dll	 - timer.h:98]	WebCore::Timer<WebCore::PageCache>::fired()
0x6d09f4c7	 [chrome.dll	 - threadtimers.cpp:112]	WebCore::ThreadTimers::sharedTimerFiredInternal()
0x6d09f43a	 [chrome.dll	 - threadtimers.cpp:90]	WebCore::ThreadTimers::sharedTimerFired()
0x6cc0be0e	 [chrome.dll	 - message_loop.cc:328]	MessageLoop::RunTask(Task *)
0x6cc0be4b	 [chrome.dll	 - message_loop.cc:336]	MessageLoop::DeferOrRunPendingTask(MessageLoop::PendingTask const &)
0x6cc0bfe1	 [chrome.dll	 - message_loop.cc:443]	MessageLoop::DoWork()
0x6cc1c343	 [chrome.dll	 - message_pump_default.cc:50]	base::MessagePumpDefault::Run(base::MessagePump::Delegate *)
0x6cc0bcb9	 [chrome.dll	 - message_loop.cc:204]	MessageLoop::RunInternal()
0x6cc0bc3e	 [chrome.dll	 - message_loop.cc:176]	MessageLoop::RunHandler()
0x6cc0bbec	 [chrome.dll	 - message_loop.cc:154]	MessageLoop::Run()
0x6cc2eb81	 [chrome.dll	 - renderer_main.cc:293]	RendererMain(MainFunctionParams const &)
0x6cb43bb1	 [chrome.dll	 - chrome_dll_main.cc:730]	ChromeMain
0x012f356c	 [chrome.exe	 - client_util.cc:200]	MainDllLoader::Launch(HINSTANCE__ *,sandbox::SandboxInterfaceInfo *)
0x012f3b5b	 [chrome.exe	 - chrome_exe_main.cc:46]	wWinMain
Comment 2 Finnur Thorarinsson 2010-07-21 09:28:07 PDT
Created attachment 62194 [details]
Proposed fix
Comment 3 Finnur Thorarinsson 2010-07-21 09:47:51 PDT
Created attachment 62197 [details]
Added to the description in the changelog
Comment 4 Dimitri Glazkov (Google) 2010-07-21 09:54:52 PDT
Comment on attachment 62197 [details]
Added to the description in the changelog

ok.
Comment 5 WebKit Commit Bot 2010-07-21 10:44:53 PDT
Comment on attachment 62197 [details]
Added to the description in the changelog

Clearing flags on attachment: 62197

Committed r63841: <http://trac.webkit.org/changeset/63841>
Comment 6 WebKit Commit Bot 2010-07-21 10:44:58 PDT
All reviewed patches have been landed.  Closing bug.