Bug 42723 – FileReader needs addEventListener

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Ridley Combs]

The FileReader class currently doesn't implement addEventListener, which it... should. Leaving defining object.oneventname as the only way to define events results in some pages not working in WebKit (i.e. those that use addEventListener).

[Luis]

I confirm this in version 534.24 (branches/chromium/696@81543) with a few corrections.
This applies to the WebCore component, not JavaScriptCore.
(According to the JavaScript Console) the FileReader interface is missing the entire EventTarget interface despite the current File API specification's draft stipulating it (http://www.w3.org/TR/FileAPI/#FileReader-interface):
'FileReader implements EventTarget;'.
Oddly, it's present in the source code
http://trac.webkit.org/browser/trunk/Source/WebCore/fileapi/FileReader.idl
and has been for a while.
However, I'm not seeing a reference to 'FileReader' show up in 'EventTarget* toEventTarget(JSC::JSValue value)' where it perhaps should (I honestly don't know):
http://trac.webkit.org/browser/trunk/Source/WebCore/bindings/js/JSEventTarget.cpp
Somewhere down the line, the right source code isn't getting generated.

[Jeff Schiller]

It's in the spec too:

http://www.w3.org/TR/FileAPI/#FileReader-interface
http://www.w3.org/TR/domcore/#eventtarget

[Jian Li]

Created attachment 121197 [details]
Proposed Patch

[Adam Barth]

Comment on attachment 121197 [details]
Proposed Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=121197&action=review

> LayoutTests/fast/files/file-reader-event-listener.html:40
> +    if (layoutTestController.notifyDone)

Do you mean:
if (window.layoutTestController)
    layoutTestController.notifyDone();
?

> LayoutTests/fast/files/file-reader-event-listener.html:84
> +    window.onload = runTests;

Should we alert a message if eventSender isn't present?

[David Levin]

Comment on attachment 121197 [details]
Proposed Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=121197&action=review

> LayoutTests/fast/files/file-reader-event-listener.html:82
> +    layoutTestController.dumpAsText();

if (window.layoutTestController) around these lines.

[Jian Li]

Committed as http://trac.webkit.org/changeset/104180.