Summary: | WebKitTestRunner needs layoutTestController.setAppCacheMaximumSize | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | andersca, kling, webkit.review.bot | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | OS X 10.5 | ||||||||||
Attachments: |
|
Description
Sam Weinig
2010-07-20 15:17:30 PDT
Created attachment 109175 [details]
patch
1. Implemented layoutTestController.setAppCacheMaximumSize.
2. To keep the test result consistent, implemented layoutTestController.clearApplicationCache and call clearApplicationCache() when layoutTest startup.
Attachment 109175 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h:130: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h:128: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 2 in 13 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 109178 [details]
patch2
Fix style issue.
Comment on attachment 109178 [details] patch2 View in context: https://bugs.webkit.org/attachment.cgi?id=109178&action=review > Source/WebKit2/WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:104 > + cacheStorage().setMaximumSize(size); Shouldn't this be guarded by a termination disabler? Created attachment 109296 [details]
patch3
Based on Kling's comments make a change.
Comment on attachment 109296 [details]
patch3
LGTM.
Comment on attachment 109296 [details] patch3 Clearing flags on attachment: 109296 Committed r96405: <http://trac.webkit.org/changeset/96405> All reviewed patches have been landed. Closing bug. |