Bug 42696

Summary: WebKitTestRunner needs layoutTestController.elementDoesAutoCompleteForElementWithId
Product: WebKit Reporter: Sam Weinig <sam>
Component: WebKit2Assignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, gyuyoung.kim, jochen, kling, mifenton, rakuco, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Sam Weinig
Reported 2010-07-20 15:16:55 PDT
WebKitTestRunner needs layoutTestController.elementDoesAutoCompleteForElementWithId
Attachments
Patch (30.48 KB, patch)
2013-02-28 14:49 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (28.63 KB, patch)
2013-03-06 14:59 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2010-07-20 15:31:10 PDT
<rdar://problem/8213840>
Benjamin Poulain
Comment 2 2013-02-28 14:49:32 PST
Created attachment 190814 [details] Patch
Benjamin Poulain
Comment 3 2013-03-06 00:47:22 PST
Ping? The patch is long but it is verrry easy.
Andreas Kling
Comment 4 2013-03-06 04:28:48 PST
Comment on attachment 190814 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190814&action=review r=me, nice API change. > Source/WebCore/ChangeLog:9 > + Since the method acts direclty on a WebCore element and strictly test > + HTMLInputElement::shouldAutoComplete(), the test function is moved to internals. Typo, directly. > Source/WebCore/testing/Internals.cpp:1096 > +bool Internals::elementShouldAutoComplete(Element* element, ExceptionCode& ec) I'd pass a const Element* to a method like this.
Benjamin Poulain
Comment 5 2013-03-06 14:59:06 PST
Created attachment 191838 [details] Patch
Benjamin Poulain
Comment 6 2013-03-06 17:19:37 PST
Comment on attachment 191838 [details] Patch Clearing flags on attachment: 191838 Committed r145012: <http://trac.webkit.org/changeset/145012>
Benjamin Poulain
Comment 7 2013-03-06 17:19:42 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.