Bug 42687

Summary: WebKitTestRunner needs layoutTestController.setTabKeyCyclesThroughElements
Product: WebKit Reporter: Sam Weinig <sam>
Component: WebKit2Assignee: Sudarsana Nagineni (babu) <naginenis>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, gyuyoung.kim, kenneth, naginenis, rakuco, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Sam Weinig
Reported 2010-07-20 15:14:15 PDT
WebKitTestRunner needs layoutTestController.setTabKeyCyclesThroughElements
Attachments
Patch (7.71 KB, patch)
2012-09-06 08:54 PDT, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
Patch (7.74 KB, patch)
2012-09-07 01:21 PDT, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
Patch (7.71 KB, patch)
2012-09-11 07:49 PDT, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
Patch (7.73 KB, patch)
2012-09-11 08:44 PDT, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
Patch (9.63 KB, patch)
2012-09-14 04:01 PDT, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2010-07-20 15:32:05 PDT
<rdar://problem/8213855>
Sudarsana Nagineni (babu)
Comment 2 2012-09-06 08:54:16 PDT
Created attachment 162517 [details] Patch
Kenneth Rohde Christiansen
Comment 3 2012-09-07 00:46:14 PDT
Comment on attachment 162517 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162517&action=review > Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:106 > > +WK_EXPORT void WKBundleSetTabKeyCyclesThroughElements(WKBundleRef bundle, WKBundlePageRef page, bool cycles); This sounds so much more like a runtime setting. bool enable?
Sudarsana Nagineni (babu)
Comment 4 2012-09-07 01:21:35 PDT
Created attachment 162704 [details] Patch Take Kenneth's feedback into consideration.
Sudarsana Nagineni (babu)
Comment 5 2012-09-11 07:49:24 PDT
Created attachment 163362 [details] Patch rebased.
Sudarsana Nagineni (babu)
Comment 6 2012-09-11 08:44:53 PDT
Created attachment 163375 [details] Patch Rebased once again.
Chris Dumez
Comment 7 2012-09-14 01:59:34 PDT
Comment on attachment 163375 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163375&action=review > LayoutTests/platform/wk2/Skipped:-467 > -fast/events/keypress-insert-tab.html Shouldn't you remove it from LayoutTests/platform/efl/Skipped as well? or move it to efl-wk1/TestExpectations if it fails for WebKit1.
Chris Dumez
Comment 8 2012-09-14 02:01:33 PDT
Comment on attachment 163375 [details] Patch Shouldn't we reset the value in TestController::resetStateToConsistentValues() to avoid flakyness?
Sudarsana Nagineni (babu)
Comment 9 2012-09-14 04:01:00 PDT
Created attachment 164096 [details] Patch Take Chris's feedback into consideration.
Chris Dumez
Comment 10 2012-09-14 04:30:36 PDT
Comment on attachment 164096 [details] Patch LGTM. Thanks.
WebKit Review Bot
Comment 11 2012-09-14 06:27:37 PDT
Comment on attachment 164096 [details] Patch Clearing flags on attachment: 164096 Committed r128604: <http://trac.webkit.org/changeset/128604>
WebKit Review Bot
Comment 12 2012-09-14 06:27:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.