Bug 42684

Summary: WebKitTestRunner needs layoutTestController.setCacheModel
Product: WebKit Reporter: Sam Weinig <sam>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, gyuyoung.kim, kenneth, laszlo.gombos, sam, tonikitoo, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 50705    
Attachments:
Description Flags
Patch
buildbot: commit-queue-
Patch none

Sam Weinig
Reported 2010-07-20 15:13:24 PDT
WebKitTestRunner needs layoutTestController.setCacheModel
Attachments
Patch (10.02 KB, patch)
2012-11-14 04:40 PST, Chris Dumez 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Patch (9.77 KB, patch)
2012-11-14 05:44 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2010-07-20 15:32:23 PDT
<rdar://problem/8213860>
Chris Dumez
Comment 2 2012-11-14 04:40:34 PST
Created attachment 174130 [details] Patch
Mikhail Pozdnyakov
Comment 3 2012-11-14 04:52:51 PST
Comment on attachment 174130 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174130&action=review > Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:44 > +WK_EXPORT void WKBundleSetCacheModel(WKBundleRef bundle, uint32_t cacheModel); 'bundle' can be omitted.
Chris Dumez
Comment 4 2012-11-14 04:55:14 PST
Comment on attachment 174130 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174130&action=review >> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:44 >> +WK_EXPORT void WKBundleSetCacheModel(WKBundleRef bundle, uint32_t cacheModel); > > 'bundle' can be omitted. No other function in this file is omitting "bundle" so it would look inconsistent.
Build Bot
Comment 5 2012-11-14 05:00:03 PST
Comment on attachment 174130 [details] Patch Attachment 174130 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14834277
Mikhail Pozdnyakov
Comment 6 2012-11-14 05:17:52 PST
Comment on attachment 174130 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174130&action=review >>> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:44 >>> +WK_EXPORT void WKBundleSetCacheModel(WKBundleRef bundle, uint32_t cacheModel); >> >> 'bundle' can be omitted. > > No other function in this file is omitting "bundle" so it would look inconsistent. ok
Chris Dumez
Comment 7 2012-11-14 05:44:46 PST
Created attachment 174139 [details] Patch
Chris Dumez
Comment 8 2012-11-18 11:55:47 PST
Any feedback on this patch?
WebKit Review Bot
Comment 9 2012-11-22 05:24:26 PST
Comment on attachment 174139 [details] Patch Clearing flags on attachment: 174139 Committed r135508: <http://trac.webkit.org/changeset/135508>
WebKit Review Bot
Comment 10 2012-11-22 05:24:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.