Bug 42677 – Chrome browser Bug: Pause button stays when <audio> hits end

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Pranav Kedia]

This is a copy of bug 21739 on Chrome browser. Please see http://code.google.com/p/chromium/issues/detail?id=21739. Here is the description taken from the bug 21739:

In chrome browser, go to http://en.wikipedia.org/wiki/The_Star-Spangled_Banner and click "play" on one of the media files (right hand side of screen). Notice that when the file hits the end, the "pause" button stays a "pause" button rather than turning into "play". This seems kinda broken. (I would expect the slider to return to the beginning and the button to turn to "play").

The fix of this bug is in WebKit/WebCore/rendering/RenderMediaControlsChromium.cpp. Hence filing this bug. Here is the diff of the fix:

pranavk@pranavk-l1:/usr/local/google/home/pranavk/chrome/src/third_party/WebKit/WebCore$ svn diff
Index: rendering/RenderMediaControlsChromium.cpp
===================================================================
--- rendering/RenderMediaControlsChromium.cpp	(revision 62294)
+++ rendering/RenderMediaControlsChromium.cpp	(working copy)
@@ -96,7 +96,7 @@
     if (!hasSource(mediaElement))
         return paintMediaButton(paintInfo.context, rect, mediaPlayDisabled);
 
-    return paintMediaButton(paintInfo.context, rect, mediaElement->paused() ? mediaPlay : mediaPause);
+    return paintMediaButton(paintInfo.context, rect, mediaElement->canPlay() ? mediaPlay : mediaPause);
 }
 
 static Image* getMediaSliderThumb()
pranavk@pranavk-l1:/usr/local/google/home/pranavk/chrome/src/third_party/WebKit/WebCore$

[Pranav Kedia]

Created attachment 62352 [details]
Proposed patch.

[Pranav Kedia]

Created attachment 62363 [details]
New patch based on feedback.

[Dmitry Titov]

Comment on attachment 62363 [details]
New patch based on feedback.

> Index: rendering/RenderMediaControlsChromium.cpp

It seems the patch was created while current directory was different from the root WebKit one. I'm not sure commit-queue will be able to deal with it.
Please re-submit patch created from WebKit root (where WebCore is a subdir)

[Pranav Kedia]

This proposed fix has been taken from the function MediaControlPlayButtonElement::updateDisplayType() in http://trac.webkit.org/browser/trunk/WebCore/rendering/MediaControlElements.cpp

[Pranav Kedia]

Created attachment 62620 [details]
New revised patch after fresh enlistment in WebKit. The path issues should be resolved.

[Adam Barth]

Comment on attachment 62620 [details]
New revised patch after fresh enlistment in WebKit. The path issues should be resolved.

Nice.  Thanks.  Do we need to update the test_expectations.txt?

[WebKit Commit Bot]

Comment on attachment 62620 [details]
New revised patch after fresh enlistment in WebKit. The path issues should be resolved.

Clearing flags on attachment: 62620

Committed r64128: <http://trac.webkit.org/changeset/64128>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.