Summary: | Chrome browser Bug: Pause button stays when <audio> hits end | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pranav Kedia <pranavk> | ||||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ajwong, commit-queue, dimich, pranavk | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | OS X 10.5 | ||||||||||
URL: | http://code.google.com/p/chromium/issues/detail?id=21739 | ||||||||||
Attachments: |
|
Description
Pranav Kedia
2010-07-20 15:01:31 PDT
Created attachment 62352 [details]
Proposed patch.
Created attachment 62363 [details]
New patch based on feedback.
Comment on attachment 62363 [details] New patch based on feedback. > Index: rendering/RenderMediaControlsChromium.cpp It seems the patch was created while current directory was different from the root WebKit one. I'm not sure commit-queue will be able to deal with it. Please re-submit patch created from WebKit root (where WebCore is a subdir) This proposed fix has been taken from the function MediaControlPlayButtonElement::updateDisplayType() in http://trac.webkit.org/browser/trunk/WebCore/rendering/MediaControlElements.cpp Created attachment 62620 [details]
New revised patch after fresh enlistment in WebKit. The path issues should be resolved.
Comment on attachment 62620 [details]
New revised patch after fresh enlistment in WebKit. The path issues should be resolved.
Nice. Thanks. Do we need to update the test_expectations.txt?
Comment on attachment 62620 [details] New revised patch after fresh enlistment in WebKit. The path issues should be resolved. Clearing flags on attachment: 62620 Committed r64128: <http://trac.webkit.org/changeset/64128> All reviewed patches have been landed. Closing bug. |