| Summary: | [EFL] Implement input method notification | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Lucas De Marchi <lucas.de.marchi> | ||||||
| Component: | WebKit EFL | Assignee: | Lucas De Marchi <lucas.de.marchi> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | barbieri, commit-queue, gyuyoung.kim, kenneth, tonikitoo | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Lucas De Marchi
2010-07-20 07:14:35 PDT
Created attachment 62073 [details]
Patch
maybe it makes sense to make use of the newly added EditorClientEfl::willSetInputMethodState for editor hint "settage" (?) void EditorClientEfl::willSetInputMethodState() It was added specifically for that by Chromium guys. Other ports like Qt have not adapted themselves to make use of it, though. Could you check? (In reply to comment #2) > maybe it makes sense to make use of the newly added EditorClientEfl::willSetInputMethodState for editor hint "settage" (?) > > void EditorClientEfl::willSetInputMethodState() It's not feasible, at least for setting the hints of the to-be-focused node. This is because when this method is called, the new node is not focused yet and there's no way to get a reference for this node. Both QT and EFL relies on focusedNode()->hasTagName(WebCore::HTMLNames::inputTag) to determine the input type. In fact, chromium guys added this method because I reported to Kenneth that their prior change had broken input hints on QT. Maybe I could add a signal on EditorClientEfl::willSetInputMethodState() to inform that a virtual keyboard should be closed, but I don't see a need since it's well accomplished by the way it is right now. Comment on attachment 62073 [details]
Patch
r=me with the below fixed.
<demarchi> ow.. and now i see there's a typo in doc
<demarchi> it's "inputmethod,changed", not "inputmethods,changed"
Created attachment 62318 [details]
Patch
Comment on attachment 62318 [details] Patch Rejecting patch 62318 from commit-queue. lucas.demarchi@profusion.mobi does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). Due to bug 30084 the commit-queue will require a restart after your change. Please contact eseidel@chromium.org to request a commit-queue restart. After restart the commit-queue will correctly respect your committer rights. Comment on attachment 62318 [details] Patch Clearing flags on attachment: 62318 Committed r63933: <http://trac.webkit.org/changeset/63933> All reviewed patches have been landed. Closing bug. |