Bug 42631 – WebKit shouldn't convert Int32 values passed to NPAPI plugins to Double

• Component: Plug-ins
• Status: RESOLVED WONTFIX

[Gil]

The bug is demonstrated in the attached javascript page (http://jsbin.com/unulu3).
Open a page containing the ms windows media player mpapi plugin, and try to set the volume level programmatically
using: player.settings.volume = newValue;
It fails without an error mesage.
If you open the same page with IE, FF, or Chrome it works.

Analysis:  
QtWebKit converts int32 parameters passed to NPAPI plugin to Double.

I attach my fix (in the file c_utility.cpp).

[Gil]

Created attachment 62057 [details]
This is a proposed fix: a rar archive with the original and the fixed cpp files.

[Diego Gonzalez]

(In reply to comment #1)
> Created an attachment (id=62057) [details]
> This is a proposed fix: a rar archive with the original and the fixed cpp files.

You should generate a patch and put it into a review process. Please read: http://webkit.org/coding/contributing.html

[Andreas Kling]

Created attachment 65048 [details]
Proposed patch

Cleaned up Gil's change into a proper patch so we can proceed forward with this.

[Darin Adler]

Comment on attachment 65048 [details]
Proposed patch

Change looks perfect, but we need a regression test for this.

review- for lack of a regression test

[Ahmad Saleem]

I am unable to find "c_utility.cpp" file in Webkit Github mirror and I think NPAPI plugin support is not available in Webkit trunk and at least Safari 14 and WebkitGTK does not have it.

I am not clear on QTBuild of Webkit using it. If it is disabled across all, can this be marked as "RESOLVED WONTFIX". Thanks!

[Radar WebKit Bug Importer]

<rdar://problem/95545174>

[Brent Fulgham]

WebKit no longer supports NSAPI plugins.