Summary: | dumpAsMarkup test conversion: create-list-from-range-selection.html and insert-list-empty-div.html | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||
Component: | HTML Editing | Assignee: | Ryosuke Niwa <rniwa> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Blocker | CC: | commit-queue, ojan, tony | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 42436 | ||||||||
Attachments: |
|
Description
Ryosuke Niwa
2010-07-19 17:42:33 PDT
Created attachment 62019 [details]
converts the tests
Will not convert create-list-with-hr.html since it demonstrates a rendering bug. Comment on attachment 62019 [details] converts the tests > Index: LayoutTests/resources/dump-as-markup.js > =================================================================== > --- LayoutTests/resources/dump-as-markup.js (revision 63331) > +++ LayoutTests/resources/dump-as-markup.js (working copy) > @@ -17,7 +17,7 @@ Markup.dump = function(opt_node) > +Markup.setNode = function(node) Can we call this setNodeToDump so it's more clear what it does? > +{ > + if (typeof node == "string") > + node = document.getElementById(node); > + if (node instanceof Node) I don't think you need this if-check. If node is not a Node here, we should error out. > + Markup.node = node This should be private, i.e., Markup._node. Created attachment 62027 [details]
removed create-list-with-hr.html and fixed per ojan's comments
Comment on attachment 62027 [details]
removed create-list-with-hr.html and fixed per ojan's comments
Wow. It's so much easier to read these expected results!
Comment on attachment 62027 [details] removed create-list-with-hr.html and fixed per ojan's comments Rejecting patch 62027 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Ojan Vafai', u'--force']" exit_code: 1 Last 500 characters of output: ommand/create-list-from-range-selection-expected.txt' patching file LayoutTests/platform/qt/editing/execCommand/insert-list-empty-div-expected.txt rm 'LayoutTests/platform/qt/editing/execCommand/insert-list-empty-div-expected.txt' patching file LayoutTests/resources/dump-as-markup.js Hunk #2 FAILED at 31. Hunk #3 succeeded at 65 with fuzz 1 (offset 10 lines). Hunk #4 succeeded at 237 (offset 12 lines). 1 out of 4 hunks FAILED -- saving rejects to file LayoutTests/resources/dump-as-markup.js.rej Full output: http://queues.webkit.org/results/3395665 Landed as http://trac.webkit.org/changeset/63873. |