Bug 42600

Summary:

[EFL] Enable Ecore-X on compile time

Product:

WebKit

Reporter:

Rafael Antognolli <antognolli+webkit>

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barbieri, commit-queue, lucas.de.marchi

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	none

Rafael Antognolli

Reported 2010-07-19 15:24:45 PDT

[EFL] Enable Ecore-X on compile time

Attachments
Patch (2.51 KB, patch) 2010-07-19 15:29 PDT, Rafael Antognolli	no flags	Details Formatted Diff Diff
Patch (2.20 KB, patch) 2010-07-20 11:57 PDT, Rafael Antognolli	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Rafael Antognolli

Comment 1 2010-07-19 15:29:31 PDT

Created attachment 62003 [details] Patch

Antonio Gomes

Comment 2 2010-07-19 17:50:23 PDT

Comment on attachment 62003 [details] Patch > diff --git a/cmake/OptionsEfl.cmake b/cmake/OptionsEfl.cmake > index 78b91283aa27c8633995a7544541900ce25d7607..48e82c0d0ee944e0cea9de57de4e570d3cf74646 100644 > --- a/cmake/OptionsEfl.cmake > +++ b/cmake/OptionsEfl.cmake > @@ -43,12 +43,10 @@ ENDIF () > SET(WTF_USE_FREETYPE 1) > ADD_DEFINITIONS(-DUSE_FREETYPE=1) > > -ADD_DEFINITIONS(-DHAVE_ECORE_X) > - > -SET(JSC_EXECUTABLE_NAME jsc) > -SET(WTF_LIBRARY_NAME wtf) > -SET(JavaScriptCore_LIBRARY_NAME javascriptcore) > -SET(WebCore_LIBRARY_NAME webcore) > +SET(JSC_EXECUTABLE_NAME jsc_efl) > +SET(WTF_LIBRARY_NAME wtf_efl) > +SET(JavaScriptCore_LIBRARY_NAME javascriptcore_efl) > +SET(WebCore_LIBRARY_NAME webcore_efl) > SET(WebKit_LIBRARY_NAME ewebkit) Is this part of the patch related to the build time detection of ecore?

Gustavo Sverzut Barbieri

Comment 3 2010-07-19 19:18:54 PDT

(In reply to comment #2) > (From update of attachment 62003 [details]) > > > diff --git a/cmake/OptionsEfl.cmake b/cmake/OptionsEfl.cmake > > index 78b91283aa27c8633995a7544541900ce25d7607..48e82c0d0ee944e0cea9de57de4e570d3cf74646 100644 > > --- a/cmake/OptionsEfl.cmake > > +++ b/cmake/OptionsEfl.cmake > > @@ -43,12 +43,10 @@ ENDIF () > > SET(WTF_USE_FREETYPE 1) > > ADD_DEFINITIONS(-DUSE_FREETYPE=1) > > > > -ADD_DEFINITIONS(-DHAVE_ECORE_X) > > - > > -SET(JSC_EXECUTABLE_NAME jsc) > > -SET(WTF_LIBRARY_NAME wtf) > > -SET(JavaScriptCore_LIBRARY_NAME javascriptcore) > > -SET(WebCore_LIBRARY_NAME webcore) > > +SET(JSC_EXECUTABLE_NAME jsc_efl) > > +SET(WTF_LIBRARY_NAME wtf_efl) > > +SET(JavaScriptCore_LIBRARY_NAME javascriptcore_efl) > > +SET(WebCore_LIBRARY_NAME webcore_efl) > > SET(WebKit_LIBRARY_NAME ewebkit) > > Is this part of the patch related to the build time detection of ecore? err, it's not... it got in the patch I generated, should be split into another patch on its own (actually I thought that got in SVN a while ago...)

Rafael Antognolli

Comment 4 2010-07-20 11:57:43 PDT

Created attachment 62097 [details] Patch Ops, my bad, sorry for that... :-/

Antonio Gomes

Comment 5 2010-07-20 12:28:27 PDT

Comment on attachment 62097 [details] Patch thank you removing the unrelated change. r=me

WebKit Commit Bot

Comment 6 2010-07-20 12:56:14 PDT

Comment on attachment 62097 [details] Patch Clearing flags on attachment: 62097 Committed r63768: <http://trac.webkit.org/changeset/63768>

WebKit Commit Bot

Comment 7 2010-07-20 12:56:19 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.