Bug 42589 – Canvas Layout Tests directory cleanup

• Component: Tools / Tests
• Status: NEW

[Matthew Delaney]

Moved security tests to appropriate location under http/security, copied in "external resources" such as file "yellow.png", updated tests to hit these copied resources.
Cleaned up mac canvas skip list, updated expected results of tests to have current results.

[Matthew Delaney]

Created attachment 62001 [details]
Patch

[Sam Weinig]

Comment on attachment 62001 [details]
Patch


> +        Copying over test resource files for canvas security tests in their new appropriate location.
> +        * http/tests/security/resources/tests.css: Added.
> +        (html.fail):
> +        (html.pass):
> +        (html.needs_check):
> +        (body):
> +        (a:link):
> +        (a:visited):
> +        (body.framed):
> +        (h1):
> +        (p):
> +        (p.notes):
> +        (ul):
> +        (.refs):
> +        (.refs ul):
> +        (.refs li):
> +        (canvas):
> +        (img.expected):
> +        (iframe):
> +        (.output):
> +        (.show_output .output, .needs_check .output):
> +        (.show_output #show_output):
> +        (.resource):
> +        (.fallback):
> +        (html.minimal body):
> +        (html.fail.minimal):
> +        (html.pass.minimal):
> +        (html.needs_check.minimal):
> +        (.minimal #d):
> +        (.minimal .expectedtext):
> +        (#passtext, #failtext):
> +        (.minimal.pass #passtext, .minimal.fail #failtext):
> +        * http/tests/security/resources/tests.js: Added.
> +        (_valToString):
> +        (_hex2dec):
> +        (_warn):
> +        (_fail):
> +        (_assert):
> +        (_assertSame):
> +        (_assertDifferent):
> +        (_assertEqual):
> +        (_assertMatch):
> +        (_requireManualCheck):
> +        (_crash):
> +        (_getPixel):
> +        (_assertPixel):
> +        (_assertPixelApprox):
> +        (_addTest.window.deferTest):
> +        (_addTest.endTest):
> +        (_addTest.window.wrapFunction.return.try):
> +        (_addTest.window.wrapFunction):
> +        (_addTest.window.onload):
> +        (_addTest):

Please remove this gunk.

[Matthew Delaney]

Created attachment 62005 [details]
Previous patch minus changelog junk

Updated with Sam's suggestion to get rid of method call junk in Changelog

[WebKit Commit Bot]

Comment on attachment 62005 [details]
Previous patch minus changelog junk

Rejecting patch 62005 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Sam Weinig', u'--force']" exit_code: 1
Last 500 characters of output:
 LayoutTests/http/tests/security/security.pattern.image.strokeStyle.html
patching file LayoutTests/http/tests/security/security.reset-expected.txt
patching file LayoutTests/http/tests/security/security.reset.html
patching file LayoutTests/http/tests/security/resources/tests.css
patching file LayoutTests/http/tests/security/resources/tests.js
patching file LayoutTests/platform/mac/Skipped
Hunk #1 FAILED at 162.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac/Skipped.rej

Full output: http://queues.webkit.org/results/3600156

[Alexey Proskuryakov]

Matt, is this actually still pending commit?

[Eric Seidel (no email)]

Does not look to have been landed.

[Matthew Delaney]

Yea, I'll need to clean this up and repost again soon. Just cleared the cq- flag for now.

[Darin Adler]

Comment on attachment 62005 [details]
Previous patch minus changelog junk

Clearing review flag on this old patch.