Bug 42553 – [EFL] Add GeolocationServiceEfl for WebKit-EFL

• Component: WebKit EFL
• Status: RESOLVED LATER

[Gyuyoung Kim]

There are no GeolocationService for WebKit-EFL

[Gyuyoung Kim]

Created attachment 61928 [details]
patch

I make a patch by referencing GeolocationServiceGtk. However, I wonder if EFL port can use g_object. Is it possible ? 
And, I want to include Dbus, Geoclue when GEOLOCATION is only turned on. But, in this patch, the packages are always required.
If you know how to configure the packages, please let me know.

[Gustavo Sverzut Barbieri]

Hi Gyuyoung Kim,

Although using Glib's geoclue client works given our ecore_glib integration, it is not the way to go. I know it works as I did include it in the cmake build myself, I don't want to see it in the official repository.

As you may know EFL provides E_DBus to provide easy access to DBus services (HAL, Udisks, ConnMan, oFono, BlueZ...) and it should be extended to support Geoclue. I already discussed that with Rasterman and he also think it is the way to go.

So first you need to implement an E_DBus sub-library called e_geoclue (see how it was done in e_connman) and let us know in e-devel mail list. After this library got in, you can easily provide the WebKit patch using it.

Yes, it is not as easy as copy & paste the Gtk file, but it is the way to go. There are interested peers in having glib-free WebKit and last week we managed to build that using CURL instead of libsoup. I hope you understand my point, this will benefit EFL overall, as people can use the geolocation from their own C/EFL apps.

[Lucas De Marchi]

If you look in bug 42286 and bug 42480, you will see that glib is almost an optional dependency now. Adding another place where we depend from glib is bad.

[Gyuyoung Kim]

(In reply to comment #2)
> Hi Gyuyoung Kim,
> 
> Although using Glib's geoclue client works given our ecore_glib integration, it is not the way to go. I know it works as I did include it in the cmake build myself, I don't want to see it in the official repository.
> 
> As you may know EFL provides E_DBus to provide easy access to DBus services (HAL, Udisks, ConnMan, oFono, BlueZ...) and it should be extended to support Geoclue. I already discussed that with Rasterman and he also think it is the way to go.
> 
> So first you need to implement an E_DBus sub-library called e_geoclue (see how it was done in e_connman) and let us know in e-devel mail list. After this library got in, you can easily provide the WebKit patch using it.
> 
> Yes, it is not as easy as copy & paste the Gtk file, but it is the way to go. There are interested peers in having glib-free WebKit and last week we managed to build that using CURL instead of libsoup. I hope you understand my point, this will benefit EFL overall, as people can use the geolocation from their own C/EFL apps.

Hello Gustavo,
Ok, I understand what your point. I will consider how to support geolocation according to your guys comments. I will update my suggesstions or new patch in here again. Thank you. :)

[Lucas De Marchi]

Hi Gyuyoung Kim,

(In reply to comment #4)
> (In reply to comment #2)
> Hello Gustavo,
> Ok, I understand what your point. I will consider how to support geolocation according to your guys comments. I will update my suggesstions or new patch in here again. Thank you. :)

Any news on this?

[Gyuyoung Kim]

Now, I don't focus on this bug. When I have free time, I will report patches again. If you have any idea or patches, please upload them. :-)

[Gyuyoung Kim]

I'd like to close this bug for now. When I have correct solution, I will reopen this bug. 

Thanks.