Bug 42547 – WebKitTestRunner needs layoutTestController.setDashboardCompatibilityMode

• Component: WebKit2
• Status: RESOLVED FIXED

[Maciej Stachowiak]

WebKitTestRunner needs layoutTestController.setDashboardCompatibilityMode

[Maciej Stachowiak]

<rdar://problem/8204917>

[Jonathan Bedard]

Created attachment 285578 [details]
Patch

[Build Bot]

Comment on attachment 285578 [details]
Patch

Attachment 285578 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1835932

New failing tests:
mathml/mathml-in-dashboard.html

[Build Bot]

Created attachment 285585 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.5

[Jonathan Bedard]

Created attachment 285589 [details]
Patch

[Darin Adler]

Comment on attachment 285589 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285589&action=review

> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:323
> +    const HashSet<Page*>& pages = PageGroup::pageGroup(pageGroup->identifier())->pages();
> +    for (HashSet<Page*>::iterator iter = pages.begin(); iter != pages.end(); ++iter)
> +        (*iter)->settings().setUsesDashboardBackwardCompatibilityMode(enabled);

Here’s how we should write this in new code (other code in tis file is old):

    for (auto& page : PageGroup::pageGroup(pageGroup->identifier())->pages())
        page->settings().setUsesDashboardBackwardCompatibilityMode(enabled);

We don’t use abbreviations in WebKit code, so code should be using "iter" (even though there are many other functions in this file doing it). And with a C++11 for loop we don’t need to bother with a local variable.

> Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:420
> +    fputs("Dashboard unsupported\n", stderr);

This isn’t a good idea. The test runner should not be writing things out directly to stderr.

[Jonathan Bedard]

Created attachment 286602 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 286602 [details]
Patch

Rejecting attachment 286602 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 286602, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
/git.webkit.org/WebKit
   1faa5bf..d95384d  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 205093 = 1faa5bf9266d53f8f9c1608d5eade57c354a00ad
r205094 = d95384d3d87658680c88eef17a66218ee4bf1d38
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/1956872

[Jonathan Bedard]

Created attachment 287281 [details]
Patch

[Darin Adler]

Comment on attachment 287281 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=287281&action=review

> LayoutTests/platform/ios-simulator-wk2/TestExpectations:92
> +# iOS is missing some dashboard features

Dashboard is a Mac-specific feature. We don't need the dashboard features on any other platform. This test should be treated as a Mac-only test and no comment should imply a future plan to add this to any other platform (including iOS).

[Jonathan Bedard]

Created attachment 287298 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 287298 [details]
Patch

Clearing flags on attachment: 287298

Committed r205379: <http://trac.webkit.org/changeset/205379>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.