Bug 42539

Summary: WebKitTestRunner needs to support printing ALERT, PROMPT and CONFIRM messages
Product: WebKit Reporter: Maciej Stachowiak <mjs>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: sam, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch andersca: review+

Description Maciej Stachowiak 2010-07-18 21:42:18 PDT
WebKitTestRunner needs to support printing ALERT, PROMPT and CONFIRM messages
Comment 1 Maciej Stachowiak 2010-07-18 21:51:20 PDT
<rdar://problem/8204909>
Comment 2 Sam Weinig 2010-07-21 12:58:37 PDT
Created attachment 62223 [details]
Patch
Comment 3 WebKit Review Bot 2010-07-21 13:05:04 PDT
Attachment 62223 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:72:  Extra space between WKBundlePageWillAddMessageToConsoleCallback and willAddMessageToConsole  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:73:  Extra space between WKBundlePageWillSetStatusbarTextCallback and willSetStatusbarText  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:74:  Extra space between WKBundlePageWillRunJavaScriptAlertCallback and willRunJavaScriptAlert  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:75:  Extra space between WKBundlePageWillRunJavaScriptConfirmCallback and willRunJavaScriptConfirm  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:76:  Extra space between WKBundlePageWillRunJavaScriptPromptCallback and willRunJavaScriptPrompt  [whitespace/declaration] [3]
WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:63:  _willAddMessageToConsole is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:64:  _willSetStatusbarText is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:65:  _willRunJavaScriptAlert is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:66:  _willRunJavaScriptConfirm is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:67:  _willRunJavaScriptPrompt is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:199:  InjectedBundlePage::_willAddMessageToConsole is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:204:  InjectedBundlePage::_willSetStatusbarText is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:209:  InjectedBundlePage::_willRunJavaScriptAlert is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:214:  InjectedBundlePage::_willRunJavaScriptConfirm is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:219:  InjectedBundlePage::_willRunJavaScriptPrompt is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 15 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Sam Weinig 2010-07-21 13:10:53 PDT
Landed in r63850.