| Summary: | WebKitTestRunner needs to support layoutTestController.setFrameFlatteningEnabled | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Maciej Stachowiak <mjs> | ||||
| Component: | WebKit2 | Assignee: | Chang Shu <cshu> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abecsi, ap, commit-queue, cshu, kbalazs, kenneth, ossy, sam, zoltan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Maciej Stachowiak
2010-07-18 21:38:24 PDT
This should be easy to implement, there is already a WebKit2 C API for turning on frame flattening. (In reply to comment #2) > This should be easy to implement, there is already a WebKit2 C API for turning on frame flattening. Kenneth, the current api is for UIProcess. We need one for WebProcess, do I get it right? (In reply to comment #3) > (In reply to comment #2) > > This should be easy to implement, there is already a WebKit2 C API for turning on frame flattening. > > Kenneth, the current api is for UIProcess. We need one for WebProcess, do I get it right? Right :-) well then it is just calling into WebCore::Settings Per discussion on IRC with Maciej, we planned to send an InjectedBundle message from WebProcess to UIProcess, and calling WK API to set preference over there. I have managed to make the code work. But only partially, because even I used synchronous messaging from WebProcess, the 2nd message (preferenceDidChange) from UIProcess is async, and it causes some problem, I believe. I doubt we can make both messaging synchronous because the WebProcess is pending on waiting for the 1st message back. Based on my investigation, I plan to add WK API in WebProcess and notify UIProcess through preferenceDidChange message. I think the race condition of setting from UIProcess and WebProcess at the same time is not critical since there is no use case of such. Any thoughts, concerns? Thanks. It seems the notify-UIprocess part is not necessary for most of the setting changes, including this one. And we don't have to touch the preference store either. So it should be trivial as Kenneth has stated. :) Created attachment 90534 [details]
fix patch
Comment on attachment 90534 [details] fix patch Clearing flags on attachment: 90534 Committed r84721: <http://trac.webkit.org/changeset/84721> All reviewed patches have been landed. Closing bug. |