Bug 42517 – Incorrect behaviour calling Range setStart or setEnd with boundary in different document

• Component: DOM
• Status: RESOLVED FIXED

[Tim Down]

Created attachment 61903 [details]
Test case

According to the DOM Range spec, setting a Range boundary to a position within a document other than the one in which the Range currently exists should collapse the Range to the new boundary (in the new document). This works correctly in Firefox. In WebKit, we get a WRONG_DOCUMENT_ERR.

This may also affect other Range methods that move the range's boundaries, such as selectNode and selectNodeContents.

[Eric Seidel (no email)]

Created attachment 152086 [details]
Patch

[Eric Seidel (no email)]

I only removed the set* ones.  If you'd like others removed, we should file a separate bug for that.

[Ojan Vafai]

Comment on attachment 152086 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152086&action=review

> LayoutTests/fast/dom/Range/set-wrong-document-err.html:25
> +// http://www.w3.org/TR/DOM-Level-2-Traversal-Range/ranges.html#Level-2-Range-Changing
> +// http://www.w3.org/TR/dom/#interface-range

We should link to the new spec: http://www.w3.org/TR/dom/#interface-range

[Eric Seidel (no email)]

Comment on attachment 152086 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152086&action=review

>> LayoutTests/fast/dom/Range/set-wrong-document-err.html:25
>> +// http://www.w3.org/TR/dom/#interface-range
> 
> We should link to the new spec: http://www.w3.org/TR/dom/#interface-range

I linked to both. :)

[Eric Seidel (no email)]

Thanks for the bug and review!

[WebKit Review Bot]

Comment on attachment 152086 [details]
Patch

Clearing flags on attachment: 152086

Committed r122537: <http://trac.webkit.org/changeset/122537>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Lucas Forschler]

Mass moving XML DOM bugs to the "DOM" Component.