Bug 42513

Summary: [Qt] Don't unnecessarily copy QPainterPath in fillPath() and strokePath()
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebCore Misc.Assignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Performance, Qt, QtTriaged
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch
kenneth: review-
Proposed patch v2 none

Andreas Kling
Reported 2010-07-17 23:13:36 PDT
GraphicsContext::fillPath() and GraphicsContext::strokePath() currently deep-copy m_data->currentPath before filling/stroking with it. Since m_data->currentPath is cleared at the end of these functions, it's perfectly safe to fill/stroke using m_data->currentPath instead of a copy.
Attachments
Proposed patch (3.87 KB, patch)
2010-07-17 23:15 PDT, Andreas Kling 		kenneth: review-
DetailsFormatted DiffDiff
Proposed patch v2 (1.62 KB, patch)
2010-07-19 08:10 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2010-07-17 23:15:18 PDT
Created attachment 61901 [details] Proposed patch
Kenneth Rohde Christiansen
Comment 2 2010-07-19 05:53:21 PDT
Comment on attachment 61901 [details] Proposed patch r- due to changed requested on irc.
Andreas Kling
Comment 3 2010-07-19 08:10:32 PDT
Created attachment 61956 [details] Proposed patch v2
Andreas Kling
Comment 4 2010-07-19 19:04:02 PDT
Comment on attachment 61956 [details] Proposed patch v2 Clearing flags on attachment: 61956 Committed r63706: <http://trac.webkit.org/changeset/63706>
Andreas Kling
Comment 5 2010-07-19 19:04:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.