Bug 42480

Summary: [EFL] Cleanup glib support (make it optional)
Product: WebKit Reporter: Rafael Antognolli <antognolli+webkit>
Component: WebKit EFLAssignee: Rafael Antognolli <antognolli+webkit>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, lucas.de.marchi, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on: 42286    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Rafael Antognolli
Reported 2010-07-16 13:50:13 PDT
[EFL] Cleanup glib support (make it optional)
Attachments
Patch (8.98 KB, patch)
2010-07-16 14:20 PDT, Rafael Antognolli 		no flags
DetailsFormatted DiffDiff
Patch (10.27 KB, patch)
2010-07-16 16:18 PDT, Rafael Antognolli 		no flags
DetailsFormatted DiffDiff
Patch (11.88 KB, patch)
2010-07-23 10:30 PDT, Rafael Antognolli 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Rafael Antognolli
Comment 1 2010-07-16 14:20:22 PDT
Created attachment 61846 [details] Patch
Rafael Antognolli
Comment 2 2010-07-16 16:18:17 PDT
Created attachment 61858 [details] Patch
Antonio Gomes
Comment 3 2010-07-19 13:39:46 PDT
Comment on attachment 61858 [details] Patch r=me
Antonio Gomes
Comment 4 2010-07-19 13:42:03 PDT
svn-apply does not seem to deal fine with file create, lets wait. Please if cq fails, get acidx to land it manually.
WebKit Commit Bot
Comment 5 2010-07-19 22:42:32 PDT
Comment on attachment 61858 [details] Patch Rejecting patch 61858 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Antonio Gomes', u'--force']" exit_code: 1 Last 500 characters of output: AILED -- saving rejects to file WebKit/CMakeListsEfl.txt.rej patching file WebKit/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebKit/efl/ChangeLog patching file WebKit/efl/ewk/ewk_main.cpp Hunk #2 succeeded at 88 (offset -2 lines). patching file cmake/FindGthread.cmake patching file cmake/OptionsEfl.cmake Hunk #1 FAILED at 17. Hunk #2 FAILED at 83. Hunk #3 succeeded at 84 with fuzz 2 (offset -17 lines). 2 out of 3 hunks FAILED -- saving rejects to file cmake/OptionsEfl.cmake.rej Full output: http://queues.webkit.org/results/3369672
Rafael Antognolli
Comment 6 2010-07-23 10:30:10 PDT
Created attachment 62443 [details] Patch
Rafael Antognolli
Comment 7 2010-07-23 10:34:14 PDT
I've just updated this patch to match the changes in bug 42286, and also removed some mentions to GTK libraries and headers (though I think it wasn't finding it anyway, so there shouldn't be any problem).
Antonio Gomes
Comment 8 2010-07-23 17:54:40 PDT
Comment on attachment 62443 [details] Patch r=me
WebKit Commit Bot
Comment 9 2010-07-23 18:48:49 PDT
Comment on attachment 62443 [details] Patch Clearing flags on attachment: 62443 Committed r64005: <http://trac.webkit.org/changeset/64005>
WebKit Commit Bot
Comment 10 2010-07-23 18:48:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.