Bug 42464 – Really add WARN_UNUSED_RESULT to leakRef

• Component: New Bugs
• Status: RESOLVED FIXED

[Anders Carlsson]

Really add WARN_UNUSED_RESULT to leakRef and leakPtr

[Anders Carlsson]

Created attachment 61819 [details]
Patch

[WebKit Review Bot]

Attachment 61819 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
JavaScriptCore/wtf/PassRefPtr.h:155:  More than one command on the same line  [whitespace/newline] [4]
JavaScriptCore/wtf/RetainPtr.h:74:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[David Levin]

Comment on attachment 61819 [details]
Patch

> diff --git a/JavaScriptCore/ChangeLog b/JavaScriptCore/ChangeLog
> +        * wtf/RetainPtr.h:
> +        (WTF::RetainPtr::releaseRef):
> +        Remove WARN_UNUSED_RESULT here for now, it leads to two warnings that need
> +        to be fixed first.

fwiw, you appear to only have fixed one of them.

[Anders Carlsson]

(In reply to comment #3)
> (From update of attachment 61819 [details])
> > diff --git a/JavaScriptCore/ChangeLog b/JavaScriptCore/ChangeLog
> > +        * wtf/RetainPtr.h:
> > +        (WTF::RetainPtr::releaseRef):
> > +        Remove WARN_UNUSED_RESULT here for now, it leads to two warnings that need
> > +        to be fixed first.
> 
> fwiw, you appear to only have fixed one of them.

I fixed the single RefPtr leakRef warning. There are two RetainPtr leakPtr calls that I would need to fix first before adding back WARN_UNUSED_RESULT on RetainPtr.

[Anders Carlsson]

Committed r63562: <http://trac.webkit.org/changeset/63562>

[David Levin]

(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 61819 [details] [details])
> > > diff --git a/JavaScriptCore/ChangeLog b/JavaScriptCore/ChangeLog
> > > +        * wtf/RetainPtr.h:
> > > +        (WTF::RetainPtr::releaseRef):
> > > +        Remove WARN_UNUSED_RESULT here for now, it leads to two warnings that need
> > > +        to be fixed first.
> > 
> > fwiw, you appear to only have fixed one of them.
> 
> I fixed the single RefPtr leakRef warning. There are two RetainPtr leakPtr calls that I would need to fix first before adding back WARN_UNUSED_RESULT on RetainPtr.

Of course, you said it right there. Sorry about that.

[WebKit Review Bot]

http://trac.webkit.org/changeset/63562 might have broken Chromium Win Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/63561
http://trac.webkit.org/changeset/63562
http://trac.webkit.org/changeset/63563