Bug 42427
| Summary: | rebaseline tools should ensure that the expected.txt files have LF line endings | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ojan Vafai <ojan> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | abarth, eric, morrita, tony, victorw |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
Ojan Vafai
A bunch of the checked in chromium-win expectations have CRLF line endings. This means that when someone changes the expectations on mac/linux, all the line endings change and the diff is useless. The tool should ensure the line-endings are correct. I wonder if this is breaking because of using the tool with git. Maybe it doesn't set eol-style correctly there?
Adam, Eric, I CCed you because the new tool will have the same problem.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Victor Wang
The rebaseline tool used to set prop for new baselines. This extra step was removed by patch https://bugs.webkit.org/show_bug.cgi?id=41153 when morrita refactor the code to use SCM.