Bug 42424

Summary: If needed, NPN_GetURL the src URL
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch sam: review+

Anders Carlsson
Reported 2010-07-15 16:47:03 PDT
If needed, NPN_GetURL the src URL
Attachments
Patch (3.39 KB, patch)
2010-07-15 16:48 PDT, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2010-07-15 16:48:02 PDT
Created attachment 61746 [details] Patch
WebKit Review Bot
Comment 2 2010-07-15 16:52:09 PDT
Attachment 61746 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:69: NPP_URLNotify is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:70: NPP_GetValue is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:198: NetscapePlugin::NPP_GetValue is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 3 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2010-07-15 17:08:02 PDT
Committed r63497: <http://trac.webkit.org/changeset/63497>
Note You need to log in before you can comment on or make changes to this bug.