Summary: | Crash entering mail.yahoo.com | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, eric, ggaren, mitz, oliver, webkit.review.bot | ||||
Priority: | P1 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | OS X 10.5 | ||||||
URL: | http://mail.yahoo.com | ||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2010-07-15 13:12:10 PDT
Created attachment 61757 [details]
Patch
Comment on attachment 61757 [details]
Patch
r=me. but if the removed null check is not directly related to the other change, please say so in the ChangeLog.
How come there’s no regression test? Committed r63515: <http://trac.webkit.org/changeset/63515> http://trac.webkit.org/changeset/63515 might have broken Chromium Win Release The following changes are on the blame list: http://trac.webkit.org/changeset/63514 http://trac.webkit.org/changeset/63515 http://trac.webkit.org/changeset/63516 http://trac.webkit.org/changeset/63517 http://trac.webkit.org/changeset/63518 (In reply to comment #4) > How come there’s no regression test? Sorry -- forgot to include a test in the patch I uploaded, but I did include a patch in the final commit. |