Summary: | [Qt] Replace qMemCopy() usage with memcpy() | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Robin Burchell <viroteck> | ||||||||
Component: | WebKit Qt | Assignee: | QtWebKit Unassigned <webkit-qt-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Enhancement | CC: | commit-queue, kling | ||||||||
Priority: | P3 | Keywords: | Qt, QtTriaged | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Robin Burchell
2010-07-15 12:10:57 PDT
Hi Robin! Your patch needs a ChangeLog entry, see this page for more information: https://trac.webkit.org/wiki/QtWebKitContrib Created attachment 61797 [details]
Same as v1, with ChangeLog entry.
Fixed. Sorry about that. ;)
Comment on attachment 61797 [details] Same as v1, with ChangeLog entry. >WebCore/ChangeLog:7 > + Missing a description of this change and why it's needed. :) Comment on attachment 61797 [details] Same as v1, with ChangeLog entry. > +2010-07-16 Robin Burchell <robin.burchell@collabora.co.uk> > + > + Reviewed by NOBODY (OOPS!). > + > + [Qt] Use memcpy() instead of qMemCopy() > + See: https://bugs.webkit.org/show_bug.cgi?id=42392 Robin, please explain in the change log why changing it make sense. When uploading a new patch, please fill "Reviewed by" with "Antonio Gomes" and you wont need to get it re-reviewed. Just set "cq?" Created attachment 61946 [details]
v3, with added details (again) in ChangeLog
Fixed ChangeLog info.
Comment on attachment 61946 [details] v3, with added details (again) in ChangeLog Clearing flags on attachment: 61946 Committed r63660: <http://trac.webkit.org/changeset/63660> All reviewed patches have been landed. Closing bug. |