Bug 42392

Summary: [Qt] Replace qMemCopy() usage with memcpy()
Product: WebKit Reporter: Robin Burchell <viroteck>
Component: WebKit QtAssignee: QtWebKit Unassigned <webkit-qt-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: commit-queue, kling
Priority: P3 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch replacing qMemCopy -> memcpy
none
Same as v1, with ChangeLog entry.
tonikitoo: review+, tonikitoo: commit-queue-
v3, with added details (again) in ChangeLog none

Robin Burchell
Reported 2010-07-15 12:10:57 PDT
Created attachment 61700 [details] patch replacing qMemCopy -> memcpy Usage of memcpy() directly allows compilers to optimise more. qMemCopy() exists to allow usage in headers. See related Qt merge request at: http://qt.gitorious.org/qt/qt/merge_requests/2430 Patch attach.
Attachments
patch replacing qMemCopy -> memcpy (1.16 KB, patch)
2010-07-15 12:10 PDT, Robin Burchell 		no flags
DetailsFormatted DiffDiff
Same as v1, with ChangeLog entry. (1.32 KB, patch)
2010-07-16 06:15 PDT, Robin Burchell 		tonikitoo: review+
tonikitoo: commit-queue-
DetailsFormatted DiffDiff
v3, with added details (again) in ChangeLog (1.55 KB, patch)
2010-07-19 07:20 PDT, Robin Burchell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2010-07-16 03:19:04 PDT
Hi Robin! Your patch needs a ChangeLog entry, see this page for more information: https://trac.webkit.org/wiki/QtWebKitContrib
Robin Burchell
Comment 2 2010-07-16 06:15:33 PDT
Created attachment 61797 [details] Same as v1, with ChangeLog entry. Fixed. Sorry about that. ;)
Andreas Kling
Comment 3 2010-07-16 06:26:45 PDT
Comment on attachment 61797 [details] Same as v1, with ChangeLog entry. >WebCore/ChangeLog:7 > + Missing a description of this change and why it's needed. :)
Antonio Gomes
Comment 4 2010-07-16 06:28:27 PDT
Comment on attachment 61797 [details] Same as v1, with ChangeLog entry. > +2010-07-16 Robin Burchell <robin.burchell@collabora.co.uk> > + > + Reviewed by NOBODY (OOPS!). > + > + [Qt] Use memcpy() instead of qMemCopy() > + See: https://bugs.webkit.org/show_bug.cgi?id=42392 Robin, please explain in the change log why changing it make sense. When uploading a new patch, please fill "Reviewed by" with "Antonio Gomes" and you wont need to get it re-reviewed. Just set "cq?"
Robin Burchell
Comment 5 2010-07-19 07:20:42 PDT
Created attachment 61946 [details] v3, with added details (again) in ChangeLog Fixed ChangeLog info.
WebKit Commit Bot
Comment 6 2010-07-19 08:06:04 PDT
Comment on attachment 61946 [details] v3, with added details (again) in ChangeLog Clearing flags on attachment: 61946 Committed r63660: <http://trac.webkit.org/changeset/63660>
WebKit Commit Bot
Comment 7 2010-07-19 08:06:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.