Bug 42386

Summary:

[Chromium] Rolls Chromium DEPS forward to 52483.

Product:

WebKit

Reporter:

Victor Wang <victorw>

Component:

WebKit Misc.

Assignee:

Victor Wang <victorw>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, fishd, levin, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Bug Depends on:

42412

Bug Blocks:

Attachments:

Description	Flags
Proposed patch	levin: review+

Victor Wang

Reported 2010-07-15 10:07:43 PDT

Rolls Chromium DEPS forward to 52483 to land patch for chromium multi-dll build.

Attachments
Proposed patch (855 bytes, patch) 2010-07-15 10:12 PDT, Victor Wang	levin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Victor Wang

Comment 1 2010-07-15 10:12:54 PDT

Created attachment 61682 [details] Proposed patch

David Levin

Comment 2 2010-07-15 10:17:33 PDT

Since something similar just failed yesterday, wait to r+ this until the cr-linux build turns green. (Otherwise the EWS won't run on it.)

Victor Wang

Comment 3 2010-07-15 10:22:02 PDT

(In reply to comment #2) > Since something similar just failed yesterday, wait to r+ this until the cr-linux build turns green. (Otherwise the EWS won't run on it.) Sure, but I would also like to land it manually as soon as the cr-linux becomes green. My patch yesterday did pass cr-linux bot, however it was landed many hours late and at the time it was landed by the commit queue, cr-linux breaks due to other changes in webkit and chromium.

David Levin

Comment 4 2010-07-15 10:24:19 PDT

(In reply to comment #3) > (In reply to comment #2) > > Since something similar just failed yesterday, wait to r+ this until the cr-linux build turns green. (Otherwise the EWS won't run on it.) > > Sure, but I would also like to land it manually as soon as the cr-linux becomes green. My patch yesterday did pass cr-linux bot, however it was landed many hours late and at the time it was landed by the commit queue, cr-linux breaks due to other changes in webkit and chromium. Best not to wait for the commit queue to land it then :). r=me as soon as cr-linux turns green (so you can land it manually and fill in my name).

Victor Wang

Comment 5 2010-07-15 12:40:54 PDT

Committed r63446: <http://trac.webkit.org/changeset/63446>

WebKit Review Bot

Comment 6 2010-07-15 14:58:06 PDT

http://trac.webkit.org/changeset/63446 might have broken Chromium Win Release The following changes are on the blame list: http://trac.webkit.org/changeset/63446 http://trac.webkit.org/changeset/63447

Victor Wang

Comment 7 2010-07-15 16:16:56 PDT

(In reply to comment #6) > http://trac.webkit.org/changeset/63446 might have broken Chromium Win Release > The following changes are on the blame list: > http://trac.webkit.org/changeset/63446 > http://trac.webkit.org/changeset/63447 This is caused by chromium win bot does not have dx10+ sdk installed. jamesr just installed it and I will land the patch again.

Victor Wang

Comment 8 2010-07-15 16:51:30 PDT

Committed r63495: <http://trac.webkit.org/changeset/63495>

WebKit Review Bot

Comment 9 2010-07-15 17:11:09 PDT

http://trac.webkit.org/changeset/63495 might have broken GTK Linux 32-bit Release and Qt Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/63494 http://trac.webkit.org/changeset/63495

Note You need to log in before you can comment on or make changes to this bug.