Bug 42378

Summary:

[GTK] Get rid of libgdom

Product:

WebKit

Reporter:

Martin Robinson <mrobinson>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gustavo, webkit.review.bot, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
Patch	none
Patch fixing build issue	none
Updated patch with Xan's suggestions	none

Martin Robinson

Reported 2010-07-15 08:34:14 PDT

This intermediate library should be built straight into WebCore for speed and complexity improvements.

Attachments
Patch (44.12 KB, patch) 2010-07-15 09:30 PDT, Martin Robinson	no flags	Details Formatted Diff Diff
Patch fixing build issue (43.91 KB, patch) 2010-07-15 11:31 PDT, Martin Robinson	no flags	Details Formatted Diff Diff
Updated patch with Xan's suggestions (40.04 KB, patch) 2010-07-23 10:37 PDT, Martin Robinson	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Martin Robinson

Comment 1 2010-07-15 09:30:35 PDT

Created attachment 61672 [details] Patch

Martin Robinson

Comment 2 2010-07-15 09:32:54 PDT

Some notes on my patch for this issue: 1. Instead of sending the class list directly to the header generators and making the build depend on the GNUMakefile.am (leading to more rebuilding than necessary), I've separated to class list to a separate file. This was also necessary as we no longer list the classes in the GNUMakefile.am. 2. There was an issue where some places referenced a file in DerivedSources and some in WebKit/gtk/webkit. I've fixed that issue as well (this revealed the breakage and required fixing it). 3. The GDOM logic is now in the top-level GNUMakefile.am.

WebKit Review Bot

Comment 3 2010-07-15 10:31:36 PDT

Attachment 61672 [details] did not build on gtk: Build output: http://webkit-commit-queue.appspot.com/results/3409406

Martin Robinson

Comment 4 2010-07-15 11:31:52 PDT

Created attachment 61692 [details] Patch fixing build issue I've uploaded a patch which (hopefully) fixes the build issue. The previous patch wasn't incorrect, it just broke the dependency tracking for incremental builds. This new patch shouldn't require a clean build on the slaves.

Martin Robinson

Comment 5 2010-07-23 10:37:24 PDT

Created attachment 62447 [details] Updated patch with Xan's suggestions

Xan Lopez

Comment 6 2010-07-26 14:18:04 PDT

Comment on attachment 62447 [details] Updated patch with Xan's suggestions Looks good to me, although the ChangeLog makes some references to older versions of the patch.

Martin Robinson

Comment 7 2010-07-26 14:32:34 PDT

Committed r64075: <http://trac.webkit.org/changeset/64075>

Note You need to log in before you can comment on or make changes to this bug.