| Summary: | [GTK] Get rid of libgdom | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Martin Robinson <mrobinson> | ||||||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | gustavo, webkit.review.bot, xan.lopez | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Linux | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Martin Robinson
2010-07-15 08:34:14 PDT
Created attachment 61672 [details]
Patch
Some notes on my patch for this issue: 1. Instead of sending the class list directly to the header generators and making the build depend on the GNUMakefile.am (leading to more rebuilding than necessary), I've separated to class list to a separate file. This was also necessary as we no longer list the classes in the GNUMakefile.am. 2. There was an issue where some places referenced a file in DerivedSources and some in WebKit/gtk/webkit. I've fixed that issue as well (this revealed the breakage and required fixing it). 3. The GDOM logic is now in the top-level GNUMakefile.am. Attachment 61672 [details] did not build on gtk: Build output: http://webkit-commit-queue.appspot.com/results/3409406 Created attachment 61692 [details]
Patch fixing build issue
I've uploaded a patch which (hopefully) fixes the build issue. The previous patch wasn't incorrect, it just broke the dependency tracking for incremental builds. This new patch shouldn't require a clean build on the slaves.
Created attachment 62447 [details]
Updated patch with Xan's suggestions
Comment on attachment 62447 [details]
Updated patch with Xan's suggestions
Looks good to me, although the ChangeLog makes some references to older versions of the patch.
Committed r64075: <http://trac.webkit.org/changeset/64075> |