Bug 42339 – WebKit needs a rebaselining tool (finally)

• Component: New Bugs
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

WebKit needs a rebaselining tool (finally)

[Eric Seidel (no email)]

Created attachment 61610 [details]
Patch

[Eric Seidel (no email)]

This is a very rough approximation.  But it works. :)

I looked at bending rebaseline-chromium-webkit-tests to my will, but that effort failed.

This code could be cleaner.  Some of this code needs to be moved to shared locations.

For now just posting this for others enjoyment.  I will look at cleaning it up for landing later this week.

[Adam Barth]

Comment on attachment 61610 [details]
Patch

WebKitTools/Scripts/webkitpy/tool/commands/rebaseline.py:43
 +      help_text = "Foo"
Should have some real text here.

WebKitTools/Scripts/webkitpy/tool/commands/rebaseline.py:76
 +          chosen_name = User.prompt_with_list("Which builder to pull results from:", builder_choices)
self.tool.user for testability.

WebKitTools/Scripts/webkitpy/tool/commands/rebaseline.py:83
 +          (downloaded_file, headers) = urllib.urlretrieve(remote_file)
Does this throw exceptions?  Maybe add a FIXME?

WebKitTools/Scripts/webkitpy/tool/commands/rebaseline.py:84
 +          shutil.move(downloaded_file, local_file)
We should svn add the file in case it's new.

[Adam Barth]

I think we could land it as a first draft if we do those things.  Need iteration, of course.

[Eric Seidel (no email)]

Created attachment 61612 [details]
Patch

[Adam Barth]

Comment on attachment 61612 [details]
Patch

Ok.  This is a good start.  We'll need to refactor this into some of the lower layers at some point.

WebKitTools/Scripts/webkitpy/tool/commands/rebaseline.py:97
 +          actual_path = test_base + "-actual.txt"
This knowledge probably shouldn't be here.

[Eric Seidel (no email)]

Committed r63410: <http://trac.webkit.org/changeset/63410>