Bug 42322 – WebKitTestRunner needs to support layoutTestController.dumpBackForwardList

• Component: WebKit2
• Status: RESOLVED FIXED

[Maciej Stachowiak]

WebKitTestRunner needs to support layoutTestController.dumpBackForwardList

[Maciej Stachowiak]

<rdar://problem/8193631>

[Darin Adler]

Created attachment 71944 [details]
Patch

[WebKit Review Bot]

Attachment 71944 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit2/WebProcess/InjectedBundle/InjectedBundleBackForwardList.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundleBackForwardList.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit/mac/History/WebBackForwardListInternal.h:33:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WebKit2/WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 6 in 67 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Comment on attachment 71944 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=71944&action=review

This is going to need project changes for Qt and Windows.

> WebKit2/Shared/API/c/WKURL.cpp:44
> +    return toAPI(WebString::create(toImpl(url)->string()).leakRef());

This can call toCopiedAPI(toImpl(url)->string()) I believe.

[Darin Adler]

Committed r70723: <http://trac.webkit.org/changeset/70723>

[WebKit Review Bot]

http://trac.webkit.org/changeset/70723 might have broken GTK Linux 32-bit Release