Bug 42284

Summary:

Canvas: Rename operator==(CanvasStyle,CanvasStyle) since it isn't a proper equality check

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

kenneth

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Renamed it to isColorAndEqualTo(CanvasStyle)	kenneth: review+, kenneth: commit-queue-

Andreas Kling

Reported 2010-07-14 13:22:10 PDT

It only compares if the CanvasStyle is an RGBA or CMYKA color.

Attachments
Renamed it to isColorAndEqualTo(CanvasStyle) (3.70 KB, patch) 2010-07-14 13:25 PDT, Andreas Kling	kenneth: review+ kenneth: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Andreas Kling

Comment 1 2010-07-14 13:25:09 PDT

Created attachment 61557 [details] Renamed it to isColorAndEqualTo(CanvasStyle)

Kenneth Rohde Christiansen

Comment 2 2010-07-14 17:25:44 PDT

What about the name: isEquivalentColor ?

Andreas Kling

Comment 3 2010-07-16 06:22:07 PDT

(In reply to comment #2) > What about the name: isEquivalentColor ? r=you for that name? :)

Kenneth Rohde Christiansen

Comment 4 2010-07-19 06:33:12 PDT

Comment on attachment 61557 [details] Renamed it to isColorAndEqualTo(CanvasStyle) yes, r=me with that change.

Andreas Kling

Comment 5 2010-07-19 07:52:56 PDT

Note You need to log in before you can comment on or make changes to this bug.