Bug 42271 – [chromium] PopupMenu labels are not very visible when selected

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Jay Civelli]

- In Chromium, trigger the form autofill popup on a form
- The label on the right of the text is displayed in gray.
- Select the entry with the label.

Expected:
The text and label colors change so that they can be read with the selection background

Actual:
Only the text color changes, the label is still gray and is hard to read on the selection background

[Jay Civelli]

Created attachment 61738 [details]
Initial patch

[James Hawkins]

LGTM, thanks.

[David Levin]

Comment on attachment 61738 [details]
Initial patch

> Index: WebCore/ChangeLog
> +        (WebCore::PopupListBox::paintRow):

A short comment here would be nice.

> Index: WebCore/platform/chromium/PopupMenuChromium.cpp
> +    gc->setFillColor(textColor, DeviceColorSpace);

labelColor (as discussed).

[David Holloway]

LGTM.

[Jay Civelli]

Created attachment 61749 [details]
Applying Dave Levin's suggested changes.

[WebKit Commit Bot]

Comment on attachment 61749 [details]
Applying Dave Levin's suggested changes.

Clearing flags on attachment: 61749

Committed r63504: <http://trac.webkit.org/changeset/63504>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Zhenyao Mo]

Committed r63505: <http://trac.webkit.org/changeset/63505>