Bug 4226

Summary:

link underlines print too thickly

Product:

WebKit

Reporter:

Trey Matteson <trey>

Component:

Printing

Assignee:

Trey Matteson <trey>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

trey

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

URL:

http://www.nytimes.com/

Attachments:

Description	Flags
simple test file with one link, useful for debugging	none
cvs attrib output	none
proposed patch, per recent email	trey: review+

Trey Matteson

Reported 2005-07-30 14:34:04 PDT

Go to any page with links. Observe how the underlines look. Print the page (Preview works too). Note the underlines are way too thick. They don't look good and they do not look they did on the screen.

Attachments
simple test file with one link, useful for debugging (194 bytes, text/html) 2005-07-30 14:34 PDT, Trey Matteson	no flags	Details
cvs attrib output (1.40 KB, text/plain) 2005-07-30 14:41 PDT, Trey Matteson	no flags	Details
proposed patch, per recent email (1.59 KB, patch) 2005-07-31 22:05 PDT, Trey Matteson	trey: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Trey Matteson

Comment 1 2005-07-30 14:34:48 PDT

Created attachment 3157 [details] simple test file with one link, useful for debugging

Trey Matteson

Comment 2 2005-07-30 14:41:30 PDT

Created attachment 3158 [details] cvs attrib output The funny thing is if you look at the history of the attached method, it looks to me like John fixed it on 1/11/05 and mjs broke it two days later. This could have just been a botched merge. Removing the unconditional [graphicsContext setShouldAntialias: NO]; does seem to fix the basic case for me.

Maciej Stachowiak

Comment 3 2005-07-31 20:56:06 PDT

Yes odds are good I botched the merge - when reapplying fix please make sure international text input still looks right.

Trey Matteson

Comment 4 2005-07-31 22:05:50 PDT

Created attachment 3187 [details] proposed patch, per recent email

Darin Adler

Comment 5 2005-08-01 00:02:16 PDT

Comment on attachment 3187 [details] proposed patch, per recent email Maciej and I were talking about this on IRC and clearly he was saying "r=me".

Justin Garcia

Comment 6 2005-08-01 09:35:22 PDT

Landing this ... international text input looks OK.

John Sullivan

Comment 7 2005-08-01 09:55:45 PDT

This is also in Radar as 3965011.

Trey Matteson

Comment 8 2005-08-01 11:46:55 PDT

Comment on attachment 3187 [details] proposed patch, per recent email Hold off - I think I have a better fix

Trey Matteson

Comment 9 2005-08-01 11:52:52 PDT

Oh well, it's already in, I made a new bug - #4255

Note You need to log in before you can comment on or make changes to this bug.