Bug 42253

Summary:

REGRESSION(r61484): Broke focus behaviour on Qt and probably other platforms

Product:

WebKit

Reporter:

Kenneth Rohde Christiansen <kenneth>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Critical

CC:

commit-queue, darin, dglazkov, fishd, gustavo, hausmann, lucas.de.marchi, suzhe, tonikitoo, webkit-ews, webkit.review.bot, xan.lopez

Priority:

Keywords:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Bug Depends on:

Bug Blocks:

35784

Attachments:

Description	Flags
A patch to fix this issue.	none
Fix two typos.	none

Description Kenneth Rohde Christiansen 2010-07-14 06:01:30 PDT

r61484 changed the behaviour of setFocusedNode by calling setInputMethodState before the focused node is changed, something that Qt depended on and needs to depend on.

Comment 1 Kenneth Rohde Christiansen 2010-07-14 06:06:36 PDT

Wouldn't it have been better if the patch had introduced a method to finish ongoing composition session? or make setInputMethodState take an enum instead?

Comment 2 Kenneth Rohde Christiansen 2010-07-14 06:07:17 PDT

EFL is affected as well according to demarchi.

Comment 3 Lucas De Marchi 2010-07-14 06:29:18 PDT

This is impacting the EFL implementation as well. In setInputMethodState we need the new focused node, not the old, in order to get the input method hints.

Comment 4 James Su 2010-07-14 09:49:08 PDT

(In reply to comment #1)
> Wouldn't it have been better if the patch had introduced a method to finish ongoing composition session? or make setInputMethodState take an enum instead?

Sounds better. Why way would you prefer? a new enum or an new method?

Comment 5 James Su 2010-07-16 15:32:58 PDT

Created attachment 61852 [details]
A patch to fix this issue.

Comment 6 Early Warning System Bot 2010-07-16 15:38:31 PDT

Attachment 61852 [details] did not build on qt:
Build output: http://webkit-commit-queue.appspot.com/results/3370531

Comment 7 WebKit Review Bot 2010-07-16 15:39:14 PDT

Attachment 61852 [details] did not build on gtk:
Build output: http://webkit-commit-queue.appspot.com/results/3581076

Comment 8 WebKit Review Bot 2010-07-16 15:42:40 PDT

Attachment 61852 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/3594045

Comment 9 James Su 2010-07-16 15:50:59 PDT

Created attachment 61854 [details]
Fix two typos.

Comment 10 Darin Adler 2010-07-16 17:35:03 PDT

Can we make a regression test for this?

Comment 11 WebKit Commit Bot 2010-07-16 18:06:02 PDT

Comment on attachment 61854 [details]
Fix two typos.

Clearing flags on attachment: 61854

Committed r63602: <http://trac.webkit.org/changeset/63602>

Comment 12 WebKit Commit Bot 2010-07-16 18:06:08 PDT

All reviewed patches have been landed.  Closing bug.