Bug 42218

Summary: ES5 requires BOMs to be treated as whitespace
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, eric, tonyg, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch barraclough: review+

Oliver Hunt
Reported 2010-07-13 17:46:14 PDT
ES5 requires BOMs to be treated as whitespace
Attachments
Patch (20.74 KB, patch)
2010-07-13 17:50 PDT, Oliver Hunt 		barraclough: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2010-07-13 17:50:36 PDT
Created attachment 61440 [details] Patch
Gavin Barraclough
Comment 2 2010-07-13 17:54:17 PDT
Comment on attachment 61440 [details] Patch it would be nice if we could unify our whitespace checking methods a little – isStrWhiteSpace in JSGlobalObjectFunctions duplicates some of this.
Oliver Hunt
Comment 3 2010-07-13 18:02:29 PDT
Committed r63273: <http://trac.webkit.org/changeset/63273>
WebKit Review Bot
Comment 4 2010-07-13 18:14:48 PDT
http://trac.webkit.org/changeset/63273 might have broken Chromium Linux Release
Tony Gentilcore
Comment 5 2010-07-13 18:26:22 PDT
(In reply to comment #4) > http://trac.webkit.org/changeset/63273 might have broken Chromium Linux Release If this broke Chromium, it might be because this should have been reverted along with this change: http://trac.webkit.org/changeset/63162
Oliver Hunt
Comment 6 2010-07-13 18:34:30 PDT
(In reply to comment #5) > (In reply to comment #4) > > http://trac.webkit.org/changeset/63273 might have broken Chromium Linux Release > > If this broke Chromium, it might be because this should have been reverted along with this change: > http://trac.webkit.org/changeset/63162 Yup, bug 42224 is the rollout patch, i have a vague hope the commit bot will actually commit it at some point.
WebKit Review Bot
Comment 7 2010-07-13 18:35:05 PDT
Attachment 61440 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/3426289
Note You need to log in before you can comment on or make changes to this bug.