Bug 42218

Summary: ES5 requires BOMs to be treated as whitespace
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, eric, tonyg, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch barraclough: review+

Description Oliver Hunt 2010-07-13 17:46:14 PDT
ES5 requires BOMs to be treated as whitespace
Comment 1 Oliver Hunt 2010-07-13 17:50:36 PDT
Created attachment 61440 [details]
Patch
Comment 2 Gavin Barraclough 2010-07-13 17:54:17 PDT
Comment on attachment 61440 [details]
Patch

it would be nice if we could unify our whitespace checking methods a little – isStrWhiteSpace in JSGlobalObjectFunctions duplicates some of this.
Comment 3 Oliver Hunt 2010-07-13 18:02:29 PDT
Committed r63273: <http://trac.webkit.org/changeset/63273>
Comment 4 WebKit Review Bot 2010-07-13 18:14:48 PDT
http://trac.webkit.org/changeset/63273 might have broken Chromium Linux Release
Comment 5 Tony Gentilcore 2010-07-13 18:26:22 PDT
(In reply to comment #4)
> http://trac.webkit.org/changeset/63273 might have broken Chromium Linux Release

If this broke Chromium, it might be because this should have been reverted along with this change:
http://trac.webkit.org/changeset/63162
Comment 6 Oliver Hunt 2010-07-13 18:34:30 PDT
(In reply to comment #5)
> (In reply to comment #4)
> > http://trac.webkit.org/changeset/63273 might have broken Chromium Linux Release
> 
> If this broke Chromium, it might be because this should have been reverted along with this change:
> http://trac.webkit.org/changeset/63162

Yup, bug 42224 is the rollout patch, i have a vague hope the commit bot will actually commit it at some point.
Comment 7 WebKit Review Bot 2010-07-13 18:35:05 PDT
Attachment 61440 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/3426289