Bug 42206

Summary:

[chromium] autofill suggestion popup should show the entire text

Product:

WebKit

Reporter:

Jay Civelli <jcivelli>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dhollowa, jhawkins, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Initial patch	none
Patch for landing	none

Jay Civelli

Reported 2010-07-13 14:51:04 PDT

To ensure that users do not fill a form with information they do not realized they specified, the autofill suggestion popup should show the entire text (right now it limits the popup width to the text input width).

Attachments
Initial patch (1.37 KB, patch) 2010-07-13 14:58 PDT, Jay Civelli	no flags	Details Formatted Diff Diff
Patch for landing (1.60 KB, patch) 2010-07-14 10:17 PDT, Jay Civelli	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Jay Civelli

Comment 1 2010-07-13 14:58:55 PDT

Created attachment 61421 [details] Initial patch

James Hawkins

Comment 2 2010-07-13 15:00:33 PDT

LGTM

WebKit Review Bot

Comment 3 2010-07-13 15:01:00 PDT

Attachment 61421 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit/chromium/src/WebViewImpl.cpp:163: One space before end of line comments [whitespace/comments] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

David Levin

Comment 4 2010-07-13 15:30:29 PDT

Comment on attachment 61421 [details] Initial patch > Index: WebKit/chromium/src/WebViewImpl.cpp > + false, // restrictWidthOfListBox (for security reasons show the entire > + // entry so the user doesn't enter information it did not intend to) Please consider starting with a capital letter "For security..." and ending with a period " did no intend to."

Jay Civelli

Comment 5 2010-07-14 10:17:01 PDT

Created attachment 61532 [details] Patch for landing

WebKit Commit Bot

Comment 6 2010-07-14 19:16:40 PDT

Comment on attachment 61532 [details] Patch for landing Clearing flags on attachment: 61532 Committed r63391: <http://trac.webkit.org/changeset/63391>

WebKit Commit Bot

Comment 7 2010-07-14 19:16:45 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.