Bug 42117 – AX: Data table heuristics: consider assuming data table for 'zebra-striped' rows

• Component: Accessibility
• Status: RESOLVED FIXED

[chris fleizach]

Data table heuristics: consider assuming data table for 'zebra-striped' rows

* NOTES
We should consider adding a data table heuristic if every other row is an alternating color. 'zebra-striped' rows are a common design pattern. See screen shot that was not triggered as a data table before the ARIA roles were added.

[chris fleizach]

Created attachment 61281 [details]
Patch

[Darin Adler]

Comment on attachment 61281 [details]
Patch

> +    Vector<Color> alternatingColorCache;

Why a variable-size vector here instead of a fixed array?

[Darin Adler]

Comment on attachment 61281 [details]
Patch

> +            // For the first 5 rows, cache the background color so we can check if this table has zebra-striped rows.
> +            if (row < 5 && row == (int)alternatingColorCache.size()) {

If you have to do type casting, you should do a C++ cast, not C.

> +                alternatingColorCache.append(rowColor);

I'm not sure "cache" is the right name for this data structure. I'd just call it rowColors.

Code seems OK, I’ll say r=me

[chris fleizach]

http://trac.webkit.org/changeset/63353

[chris fleizach]

looks like the commit-log-editor chose the wrong change log