Bug 42057

Summary:

Build fix: Remove ENABLE(INSPECTOR) guard from InspectorValues.h

Product:

WebKit

Reporter:

Kwang Yul Seo <skyul>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	abarth: review-

Kwang Yul Seo

Reported 2010-07-12 00:45:57 PDT

InspectorValue and its subclasses are used in InspectorDOMAgent.h. Remove ENABLE(INSPECTOR) guard from InspectorValues.h to fix build.

Attachments
Patch (1.20 KB, patch) 2010-07-12 00:57 PDT, Kwang Yul Seo	abarth: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Kwang Yul Seo

Comment 1 2010-07-12 00:57:02 PDT

Created attachment 61193 [details] Patch

Pavel Feldman

Comment 2 2010-07-17 04:44:49 PDT

Comment on attachment 61193 [details] Patch Which build was broken? Could you please provide compile logs?

Kwang Yul Seo

Comment 3 2010-07-18 18:19:43 PDT

(In reply to comment #2) > (From update of attachment 61193 [details]) > Which build was broken? Could you please provide compile logs? I am working on WebKit Brew MP port. The build is broken when ENABLE(INSPECTOR) is FALSE.

Adam Barth

Comment 4 2010-07-27 07:23:21 PDT

Comment on attachment 61193 [details] Patch This doesn't seem right. Maybe we need more ENABLE(INSPECTOR) guards elsewhere? Why would the non-inspector build want InspectorValues?

Kwang Yul Seo

Comment 5 2010-09-20 15:45:25 PDT

(In reply to comment #4) > (From update of attachment 61193 [details]) > This doesn't seem right. Maybe we need more ENABLE(INSPECTOR) guards elsewhere? Why would the non-inspector build want InspectorValues? The problem is fixed in HEAD. Maybe more ENABLE(INSPECTOR) guards are added. Close the bug as Invalid.

Note You need to log in before you can comment on or make changes to this bug.