Bug 42032

Summary: Need to emulate MAX_VARYING_VECTORS/MAX_FRAGMENT_UNIFORM_VECTORs/MAX_VERTEX_UNIFORM_VECTORS for glGet
Product: WebKit Reporter: Zhenyao Mo <zmo>
Component: WebGLAssignee: Zhenyao Mo <zmo>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cmarrin, dglazkov, eric, kbr, oliver, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch fishd: review+, zmo: commit-queue-

Zhenyao Mo
Reported 2010-07-10 15:13:58 PDT
In desktop gl, the corresponding enums are MAX_VARYING_FLOATS/MAX_FRAGMENT_UNIFORM_COMPONENTS/MAX_VERTEX_UNIFORM_COMPONENTS. The difference is a multitude of 4.
Attachments
patch (5.35 KB, patch)
2010-07-10 15:18 PDT, Zhenyao Mo 		fishd: review+
zmo: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zhenyao Mo
Comment 1 2010-07-10 15:18:11 PDT
Created attachment 61162 [details] patch
Kenneth Russell
Comment 2 2010-07-12 17:13:08 PDT
Comment on attachment 61162 [details] patch Looks good to me.
Darin Fisher (:fishd, Google)
Comment 3 2010-07-12 20:22:28 PDT
Comment on attachment 61162 [details] patch WebCore/platform/graphics/mac/GraphicsContext3DMac.mm:1229 + *value /= 4; nit: you should explain this factor of 4 in the ChangeLog. desktop GL returns byte counts or something, and GLES2 needs to return 32bit word counts? R=me
Zhenyao Mo
Comment 4 2010-07-13 08:55:10 PDT
(In reply to comment #3) > (From update of attachment 61162 [details]) > WebCore/platform/graphics/mac/GraphicsContext3DMac.mm:1229 > + *value /= 4; > nit: you should explain this factor of 4 in the ChangeLog. desktop GL returns > byte counts or something, and GLES2 needs to return 32bit word counts? > > R=me Will add a comment in the landing patch.
Zhenyao Mo
Comment 5 2010-07-13 09:52:14 PDT
Committed r63215: <http://trac.webkit.org/changeset/63215>
WebKit Review Bot
Comment 6 2010-07-13 10:23:46 PDT
http://trac.webkit.org/changeset/63215 might have broken GTK Linux 64-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/63216 http://trac.webkit.org/changeset/63215
Note You need to log in before you can comment on or make changes to this bug.