Bug 41971

Summary: WebKit2: Add really basic BackForwardList support
Product: WebKit Reporter: Sam Weinig <sam>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch andersca: review+

Description Sam Weinig 2010-07-09 11:36:28 PDT 
Add really basic BackForwardList support.
Comment 1 Sam Weinig 2010-07-09 11:37:25 PDT 
Created attachment 61067 [details]
Patch
Comment 2 WebKit Review Bot 2010-07-09 11:40:40 PDT 
Attachment 61067 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit2/WebProcess/WebCoreSupport/WebBackForwardControllerClient.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit2/UIProcess/WebBackForwardList.cpp:48:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebKit2/UIProcess/WebBackForwardList.cpp:62:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 3 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2010-07-09 14:11:42 PDT 
Comment on attachment 61067 [details]
Patch

r+
Comment 4 Sam Weinig 2010-07-09 14:32:55 PDT 
Landed in http://trac.webkit.org/changeset/62996 with additional comments and a real changelog as requested by Anders in person.