Bug 41970

Summary:

Make check-header-includes aware of the class hierarchy

Product:

WebKit

Reporter:

Dumitru Daniliuc <dumi>

Component:

Tools / Tests

Assignee:

Dumitru Daniliuc <dumi>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

abarth, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
remove check-header-includes	eric: review+, dumi: commit-queue-

Dumitru Daniliuc

Reported 2010-07-09 11:19:29 PDT

Currently, when check-header-includes finds an unnecessary #include, it doesn't know if the class needs to be forward-declared or not. We should change it to parse the entire class hierarchy first and use that information to decide if a forward-declaration is necessary.

Attachments
remove check-header-includes (4.82 KB, patch) 2010-07-13 01:22 PDT, Dumitru Daniliuc	eric: review+ dumi: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dumitru Daniliuc

Comment 1 2010-07-13 01:13:47 PDT

Talked to eseidel about this, and it looks like scripts like this are not very useful, and instead we should be looking at the headers that include a large number of other headers, or the most included headers, and try to optimize those one at a time. So I'm closing this bug and removing check-header-includes from the repository, since even the upgraded version I have is only a marginal improvement over find-extra-includes.

Dumitru Daniliuc

Comment 2 2010-07-13 01:22:38 PDT

Created attachment 61344 [details] remove check-header-includes

Eric Seidel (no email)

Comment 3 2010-07-13 01:23:52 PDT

Comment on attachment 61344 [details] remove check-header-includes OK.

Dumitru Daniliuc

Comment 4 2010-07-13 01:30:08 PDT

patch landed: r63184.

Note You need to log in before you can comment on or make changes to this bug.