Bug 41938

Summary: Auto-generate forwarding headers used by Mac and Windows builds
Product: WebKit Reporter: Mark Rowe (bdash) <mrowe>
Component: Tools / TestsAssignee: Mark Rowe (bdash) <mrowe>
Status: NEW    
Severity: Normal CC: abecsi, darin, kbalazs, ossy, sam, zherczeg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 42078    
Attachments:
Description Flags
Proof of concept patch
none
The interesting parts of the proof of concept patch none

Mark Rowe (bdash)
Reported 2010-07-09 00:55:43 PDT
They’re messy and it’s tedious to have to manually create forwarding headers.
Attachments
Proof of concept patch (1.30 MB, patch)
2010-07-09 01:02 PDT, Mark Rowe (bdash) 		no flags
DetailsFormatted DiffDiff
The interesting parts of the proof of concept patch (15.65 KB, patch)
2010-07-09 01:12 PDT, Mark Rowe (bdash) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1 2010-07-09 01:02:49 PDT
Created attachment 61012 [details] Proof of concept patch This is a proof of concept patch that works for Mac OS X engineering builds. It doesn’t yet work in production builds though it won’t require significant changes in order to do so. It removes the various ForwardingHeaders directories which is almost certain to break Windows, but it wouldn’t take much to apply a similar strategy to the Windows build system.
Mark Rowe (bdash)
Comment 2 2010-07-09 01:04:34 PDT
This also gets rid of the duplicate copies of the ICU header files that exist in JavaScriptGlue and WebCore. Those projects gain access to JavaScriptCore’s copy as a side-effect of this change.
Mark Rowe (bdash)
Comment 3 2010-07-09 01:06:52 PDT
This also generates forwarding headers for WebCore. The intent is to deploy them in WebKit2 so that references to WebCore headers from within WebKit2 are handled in a similar manner to how references to JavaScriptCore headers from within WebCore are handled (<WebCore/Settings.h> becomes <page/Settings.h> or maybe <WebCore/page/Settings.h>). Bug 41850 is related to this aspect of the change.
Mark Rowe (bdash)
Comment 4 2010-07-09 01:12:59 PDT
Created attachment 61014 [details] The interesting parts of the proof of concept patch
Darin Adler
Comment 5 2010-07-09 08:14:06 PDT
If we can get this to work, I think we should definitely do it.
Note You need to log in before you can comment on or make changes to this bug.