Bug 41871
| Summary: | fast/loader/recursive-before-unload-crash.html is flakey on leopard | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | abarth, ap, beidson, darin |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
Eric Seidel (no email)
fast/loader/recursive-before-unload-crash.html is flakey on leopard
This has caused at least 10 commit-queue false-failures and certainly more than that delays (we test things twice on the commit-queue to avoid being sensitive to flaky tests, but the second test is only needed if we have flaky tests, thus causing delays).
To see 11 bugs which failed from this:
https://bugs.webkit.org/buglist.cgi?query_format=specific&order=relevance+desc&bug_status=__all__&product=&content=fast/loader/recursive-before-unload-crash.html
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Eric Seidel (no email)
https://trac.webkit.org/browser/trunk/LayoutTests/fast/loader/recursive-before-unload-crash.html
I can get you failure logs from the bot.
Alexey Proskuryakov
> I can get you failure logs from the bot.
Of course, please do.
Eric Seidel (no email)
My apologies. I got distracted. Here it is:
--- /tmp/layout-test-results/fast/loader/recursive-before-unload-crash-expected.txt 2010-07-09 13:38:55.000000000 -0700
+++ /tmp/layout-test-results/fast/loader/recursive-before-unload-crash-actual.txt 2010-07-09 13:38:55.000000000 -0700
@@ -6,8 +6,8 @@
main frame - didStartProvisionalLoadForFrame
ALERT: Adding iframe
frame "<!--framePath //<!--frame0-->-->" - didStartProvisionalLoadForFrame
-main frame - didCancelClientRedirectForFrame
frame "<!--framePath //<!--frame0-->-->" - didFailProvisionalLoadWithError
+main frame - didCancelClientRedirectForFrame
main frame - didFailProvisionalLoadWithError
This test demonstrates a problem with our handling of the beforeunload event.
If a script manages to try and navigate the frame from beforeunload - when a navigation is already pending - we end up blowing out the stack by recursively consulting the policy delegate then running onbeforeunloa
d repeatedly.
Eric Seidel (no email)
Looks like a race in the frame loader callbacks.
Adam Barth
The frame loader callbacks are quite racy. It's very difficult to design a test that doesn't race them.
Eric Seidel (no email)
*** This bug has been marked as a duplicate of bug 43840 ***