| Summary: | WebKit2 on Windows needs a version resource | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Steve Falkenburg <sfalken> | ||||
| Component: | WebKit2 | Assignee: | Steve Falkenburg <sfalken> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, aroben, eric, webkit.review.bot | ||||
| Priority: | P2 | Keywords: | InRadar, PlatformOnly | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Attachments: |
|
||||||
|
Description
Steve Falkenburg
2010-07-08 10:32:52 PDT
Created attachment 60909 [details]
Patch
Comment on attachment 60909 [details] Patch > Index: WebKit2/ChangeLog > =================================================================== > --- WebKit2/ChangeLog (revision 62802) > +++ WebKit2/ChangeLog (working copy) > @@ -1,3 +1,16 @@ > +2010-07-08 Steve Falkenburg <sfalken@apple.com> > + > + Reviewed by NOBODY (OOPS!). > + > + WebKit2 on Windows needs a version resource > + https://bugs.webkit.org/show_bug.cgi?id=41870 > + <rdar://problem/8170501> > + > + * win/WebKit2.rc: Added. > + * win/WebKit2.vcproj: > + * win/WebKit2WebProcess.rc: Added. > + * win/WebKit2WebProcess.vcproj: It would be great to explain the .vcproj changes, since the diffs are so unreadable. It might also be good to mention that these .rc files are veeeeeeery similar to our other .rc files. r=me Committed r62808: <http://trac.webkit.org/changeset/62808> http://trac.webkit.org/changeset/62808 might have broken Qt Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/62808 http://trac.webkit.org/changeset/62809 http://trac.webkit.org/changeset/62810 |