Bug 41870

Summary: WebKit2 on Windows needs a version resource
Product: WebKit Reporter: Steve Falkenburg <sfalken>
Component: WebKit2Assignee: Steve Falkenburg <sfalken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aroben, eric, webkit.review.bot
Priority: P2 Keywords: InRadar, PlatformOnly
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
Patch aroben: review+

Steve Falkenburg
Reported 2010-07-08 10:32:52 PDT
WebKit2 on Windows needs a version resource
Attachments
Patch (8.52 KB, patch)
2010-07-08 10:50 PDT, Steve Falkenburg 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Steve Falkenburg
Comment 1 2010-07-08 10:50:17 PDT
Created attachment 60909 [details] Patch
Adam Roben (:aroben)
Comment 2 2010-07-08 10:50:53 PDT
<rdar://problem/8170501>
Adam Roben (:aroben)
Comment 3 2010-07-08 11:12:34 PDT
Comment on attachment 60909 [details] Patch > Index: WebKit2/ChangeLog > =================================================================== > --- WebKit2/ChangeLog (revision 62802) > +++ WebKit2/ChangeLog (working copy) > @@ -1,3 +1,16 @@ > +2010-07-08 Steve Falkenburg <sfalken@apple.com> > + > + Reviewed by NOBODY (OOPS!). > + > + WebKit2 on Windows needs a version resource > + https://bugs.webkit.org/show_bug.cgi?id=41870 > + <rdar://problem/8170501> > + > + * win/WebKit2.rc: Added. > + * win/WebKit2.vcproj: > + * win/WebKit2WebProcess.rc: Added. > + * win/WebKit2WebProcess.vcproj: It would be great to explain the .vcproj changes, since the diffs are so unreadable. It might also be good to mention that these .rc files are veeeeeeery similar to our other .rc files. r=me
Steve Falkenburg
Comment 4 2010-07-08 11:35:16 PDT
Committed r62808: <http://trac.webkit.org/changeset/62808>
WebKit Review Bot
Comment 5 2010-07-08 12:01:37 PDT
http://trac.webkit.org/changeset/62808 might have broken Qt Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/62808 http://trac.webkit.org/changeset/62809 http://trac.webkit.org/changeset/62810
Note You need to log in before you can comment on or make changes to this bug.