Bug 41850 – WebKit2 needs forwarding headers

• Component: WebKit2
• Status: RESOLVED INVALID

[Balazs Kelemen]

As I mentioned at the list, the lack of forwarding headers makes problematic to porting WebKit2. Virtually, one need to copy headers into the build dir into a path that is consistent with the include directives in the files. I believe forwarding headers is a better solution.

[Balazs Kelemen]

Created attachment 60869 [details]
add forwarding headers

[Balazs Kelemen]

The headers what I added is the we use in our development branch. I can imagine that win and/or mac needs others as well. I have added platform specific ones (qgraphicswkview and qwkpage), maybe this is wrong.

[Sam Weinig]

I think this should be done the other way around to match what WebCore does.

[Balazs Kelemen]

(In reply to comment #3)
> I think this should be done the other way around to match what WebCore does.

Which way? Do you think about the whole concept or just the fact that I have added platform specif headers?

[Sam Weinig]

(In reply to comment #4)
> (In reply to comment #3)
> > I think this should be done the other way around to match what WebCore does.
> 
> Which way? Do you think about the whole concept or just the fact that I have added platform specif headers?

Instead of adding a forwarding header like ForwardingHeaders/WebCore/DragClient.h which #includes <WebCore/page/DragClient.h>, we should change WebKit2 #includes to <WebCore/page/DragClient.h> and add a forwarding header for the mac like ForwardingHeaders/WebCore/page/DragClient.h which #includes <WebCore/DragClient.h>

[Balazs Kelemen]

> Instead of adding a forwarding header like ForwardingHeaders/WebCore/DragClient.h which #includes <WebCore/page/DragClient.h>, we should change WebKit2 #includes to <WebCore/page/DragClient.h>

I assumed it is not preferred, but I think that it would be the most straightforward thing to do.

> and add a forwarding header for the mac like ForwardingHeaders/WebCore/page/DragClient.h which #includes <WebCore/DragClient.h>

I don't really understand what is it good for. Could you please clue me up?

[Mark Rowe (bdash)]

When the WebKit2 project builds on Mac OS X it has no access to the WebCore source directory, only to the built WebCore framework.  The forwarding headers exist to map from the source directory structure include paths that are used by other platforms on to the framework-style includes necessary for the Mac OS X tools to find the headers.

[Mark Rowe (bdash)]

Comment on attachment 60869 [details]
add forwarding headers

Marking as r- per Sam’s comment.

[Mark Rowe (bdash)]

I threw together some code in bug 41938 to replace the existing forwarding headers with auto-generated forwarding headers.  From there it was trivial to extend this from JavaScriptCore to WebCore.  If that patch is finished (e.g., made to work for production Mac OS X and Windows builds) then there won’t be anything to do for this bug besides moving WebKit2 from using framework-style includes to source-style includes to make the includes work on other platforms.

[Balazs Kelemen]

Since the preferred solution is to use source-style includes, I am closing this bug as invalid.

[Balazs Kelemen]

I have created bug 42078 to deal with the source-style includes solution.