Bug 41824 – Wire network times from ResourceLoadTiming to performance.timing

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Tony Gentilcore]

Wire network times from ResourceLoadTiming to performance.timing for Web Timing feature

[Tony Gentilcore]

Created attachment 61320 [details]
Patch

[Darin Fisher (:fishd, Google)]

Comment on attachment 61320 [details]
Patch

WebCore/page/Timing.cpp:84
 +      return static_cast<unsigned long long>(domainLookupStart * 1000);
nit: use 1000.0 to improve readability (same nit applies elsewhere).  a
static helper function might also be nice: toIntegerMilliseconds(double)?

R=me

[Tony Gentilcore]

(In reply to comment #2)
> (From update of attachment 61320 [details])
> WebCore/page/Timing.cpp:84
>  +      return static_cast<unsigned long long>(domainLookupStart * 1000);
> nit: use 1000.0 to improve readability (same nit applies elsewhere).  a
> static helper function might also be nice: toIntegerMilliseconds(double)?

Wow, that is so much cleaner. Thanks.

> 
> R=me

Landed r63259

[Darin Fisher (:fishd, Google)]

Note: toIntegerMilliseconds probably would have been better as a file static instead of a class static.  that way it will have internal linkage and be optimized away to nothing (although that might still happen in this case).  class statics have external linkage by default.

[Tony Gentilcore]

(In reply to comment #4)
> Note: toIntegerMilliseconds probably would have been better as a file static instead of a class static.  that way it will have internal linkage and be optimized away to nothing (although that might still happen in this case).  class statics have external linkage by default.

Great education for me. I assumed they would compile to the same thing.

I'll post a follow-up patch.