Bug 41822

Summary:

AutoFill and Autocomplete popup menu implementation has deprecated parts

Product:

WebKit

Reporter:

David Holloway <dhollowa>

Component:

Forms

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dglazkov, eric, fishd, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed patch. Removes deprecated logic.	ojan: review+, commit-queue: commit-queue-
Updated patch.	none

Description David Holloway 2010-07-07 18:05:09 PDT

The AutoFill and Autocomplete popup menu handling logic has now been consolidated into a single implementation.  This leaves some remaining deprecated logic.  This logic should be removed.

Files affected are:

* public/WebView.h
* src/AutoFillPopupMenuClient.cpp
* src/AutoFillPopupMenuClient.h
* src/WebViewImpl.cpp
* src/WebViewImpl.h

Comment 1 David Holloway 2010-07-07 18:14:36 PDT

Created attachment 60819 [details]
Proposed patch.  Removes deprecated logic.

Comment 2 WebKit Review Bot 2010-07-07 20:35:33 PDT

Attachment 60819 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/3495003

Comment 3 David Holloway 2010-07-09 12:59:56 PDT

Chromium DEPS now at a point where this patch should pass cr-linux tests.

DEPS roll in https://bugs.webkit.org/show_bug.cgi?id=41867.

Comment 4 Adam Barth 2010-08-10 22:42:52 PDT

Comment on attachment 60819 [details]
Proposed patch.  Removes deprecated logic.

Comment #3 claims this is now safe to land.

Comment 5 WebKit Commit Bot 2010-08-11 02:05:04 PDT

Comment on attachment 60819 [details]
Proposed patch.  Removes deprecated logic.

Rejecting patch 60819 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Ojan Vafai', u'--force']" exit_code: 1
Last 500 characters of output:
ving rejects to file WebKit/chromium/src/AutoFillPopupMenuClient.cpp.rej
patching file WebKit/chromium/src/AutoFillPopupMenuClient.h
Hunk #1 succeeded at 114 with fuzz 2 (offset 15 lines).
Hunk #2 succeeded at 140 (offset 21 lines).
patching file WebKit/chromium/src/WebViewImpl.cpp
Hunk #1 FAILED at 1756.
1 out of 1 hunk FAILED -- saving rejects to file WebKit/chromium/src/WebViewImpl.cpp.rej
patching file WebKit/chromium/src/WebViewImpl.h
Hunk #1 succeeded at 181 with fuzz 2 (offset 12 lines).

Full output: http://queues.webkit.org/results/3771050

Comment 6 Eric Seidel (no email) 2010-10-14 11:34:46 PDT

This needs an updated patch which applies to tip of tree.

Comment 7 David Holloway 2010-12-08 14:29:27 PST

Created attachment 75965 [details]
Updated patch.

Comment 8 Eric Seidel (no email) 2010-12-13 11:32:45 PST

Comment on attachment 75965 [details]
Updated patch.

Yay removing code!

Comment 9 WebKit Review Bot 2010-12-13 11:56:35 PST

Comment on attachment 75965 [details]
Updated patch.

Clearing flags on attachment: 75965

Committed r73940: <http://trac.webkit.org/changeset/73940>

Comment 10 WebKit Review Bot 2010-12-13 11:56:41 PST

All reviewed patches have been landed.  Closing bug.