Bug 41820

Summary:

commit-queue and EWS bots should report all failures

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

New Bugs

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Addressed Adam's comments	abarth: review+, abarth: commit-queue+

Description Eric Seidel (no email) 2010-07-07 17:50:41 PDT

commit-queue and EWS bots should report all failures

Comment 1 Eric Seidel (no email) 2010-07-07 17:54:38 PDT

Created attachment 60815 [details]
Patch

Comment 2 Adam Barth 2010-07-09 02:46:29 PDT

Comment on attachment 60815 [details]
Patch

WebKitTools/Scripts/webkitpy/tool/commands/queues.py:139
 +          log_file = cls._log_from_script_error_for_upload(script_error)
You never do anything with the log_file :)

WebKitTools/Scripts/webkitpy/tool/commands/queues.py:215
 +              failure_log = self._log_from_script_error_for_upload(e)
Inconsistent naming of the result of this function.

Comment 3 Adam Barth 2010-08-10 22:22:15 PDT

Comment on attachment 60815 [details]
Patch

Please address my comments above.

Comment 4 Eric Seidel (no email) 2010-08-24 22:10:05 PDT

Created attachment 65369 [details]
Addressed Adam's comments

Comment 5 Adam Barth 2010-08-24 22:11:28 PDT

Comment on attachment 65369 [details]
Addressed Adam's comments

ok

Comment 6 Eric Seidel (no email) 2010-08-24 22:12:06 PDT

Committed r65979: <http://trac.webkit.org/changeset/65979>

Comment 7 Eric Seidel (no email) 2010-08-24 22:19:06 PDT

I've restarted the cq and the mac-ews.  We'll know shortly if this code is working as intended.