Bug 41820

Summary: commit-queue and EWS bots should report all failures
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Addressed Adam's comments abarth: review+, abarth: commit-queue+

Eric Seidel (no email)
Reported 2010-07-07 17:50:41 PDT
commit-queue and EWS bots should report all failures
Attachments
Patch (6.59 KB, patch)
2010-07-07 17:54 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Addressed Adam's comments (6.69 KB, patch)
2010-08-24 22:10 PDT, Eric Seidel (no email) 		abarth: review+
abarth: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-07-07 17:54:38 PDT
Created attachment 60815 [details] Patch
Adam Barth
Comment 2 2010-07-09 02:46:29 PDT
Comment on attachment 60815 [details] Patch WebKitTools/Scripts/webkitpy/tool/commands/queues.py:139 + log_file = cls._log_from_script_error_for_upload(script_error) You never do anything with the log_file :) WebKitTools/Scripts/webkitpy/tool/commands/queues.py:215 + failure_log = self._log_from_script_error_for_upload(e) Inconsistent naming of the result of this function.
Adam Barth
Comment 3 2010-08-10 22:22:15 PDT
Comment on attachment 60815 [details] Patch Please address my comments above.
Eric Seidel (no email)
Comment 4 2010-08-24 22:10:05 PDT
Created attachment 65369 [details] Addressed Adam's comments
Adam Barth
Comment 5 2010-08-24 22:11:28 PDT
Comment on attachment 65369 [details] Addressed Adam's comments ok
Eric Seidel (no email)
Comment 6 2010-08-24 22:12:06 PDT
Committed r65979: <http://trac.webkit.org/changeset/65979>
Eric Seidel (no email)
Comment 7 2010-08-24 22:19:06 PDT
I've restarted the cq and the mac-ews. We'll know shortly if this code is working as intended.
Note You need to log in before you can comment on or make changes to this bug.