Bug 41818

Summary: Calling layoutTestController.layerTreeAsText() should update layout
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Tools / TestsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
mitz: review+
Patch darin: review+

Simon Fraser (smfr)
Reported 2010-07-07 17:37:23 PDT
If a test calls layoutTestController.layerTreeAsText() to fetch the layer tree, we should do any pending layouts and make sure the layer tree is up-to-date.
Attachments
Patch (13.71 KB, patch)
2010-07-08 17:34 PDT, Simon Fraser (smfr) 		mitz: review+
DetailsFormatted DiffDiff
Patch (15.64 KB, patch)
2010-07-09 17:20 PDT, Simon Fraser (smfr) 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2010-07-08 17:34:57 PDT
Created attachment 60988 [details] Patch
Simon Fraser (smfr)
Comment 2 2010-07-08 22:11:54 PDT
http://trac.webkit.org/changeset/62892
Simon Fraser (smfr)
Comment 3 2010-07-09 16:00:36 PDT
Fix was bad :(
Simon Fraser (smfr)
Comment 4 2010-07-09 16:00:42 PDT
diff --git a/WebCore/page/Frame.cpp b/WebCore/page/Frame.cpp index b3c01eb..5c878b2 100644 --- a/WebCore/page/Frame.cpp +++ b/WebCore/page/Frame.cpp @@ -1602,6 +1602,8 @@ IntRect Frame::tiledBackingStoreVisibleRect() String Frame::layerTreeAsText() const { #if USE(ACCELERATED_COMPOSITING) + document()->updateLayout(); + if (!contentRenderer()) return String(); @@ -1609,8 +1611,6 @@ String Frame::layerTreeAsText() const if (!rootLayer) return String(); - document()->updateLayout(); - return rootLayer->layerTreeAsText(); #else return String();
Simon Fraser (smfr)
Comment 5 2010-07-09 17:20:01 PDT
Created attachment 61117 [details] Patch
Simon Fraser (smfr)
Comment 6 2010-07-09 18:18:24 PDT
http://trac.webkit.org/changeset/63022
Note You need to log in before you can comment on or make changes to this bug.