|Summary:||Get my head wrapped around processCharacter|
|Product:||WebKit||Reporter:||Adam Barth <abarth>|
|Component:||New Bugs||Assignee:||Adam Barth <abarth>|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.5|
|Bug Depends on:|
Description Adam Barth 2010-07-07 16:44:08 PDT
Get my head wrapped around processCharacter
Comment 2 Eric Seidel (no email) 2010-07-07 16:47:31 PDT
Comment on attachment 60803 [details] Patch OK. I'm not sure I fully understand where you're going, but I trust you.
Comment 3 Adam Barth 2010-07-07 16:48:59 PDT
Comment on attachment 60803 [details] Patch I have the design in my head. It's cool. I just need to implement it. (I haven't figured out how to do the pending characters yet though... More research needed.)
Comment 4 WebKit Commit Bot 2010-07-08 02:58:51 PDT
Comment on attachment 60803 [details] Patch Rejecting patch 60803 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 19304 test cases. fast/loader/recursive-before-unload-crash.html -> failed Exiting early after 1 failures. 14200 tests run. 252.97s total testing time 14199 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 1 test case (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/3481021
Comment 5 Adam Barth 2010-07-08 09:33:48 PDT
Comment on attachment 60803 [details] Patch Sigh. We might need to do battle with flaky tests again.
Comment 7 WebKit Commit Bot 2010-07-08 21:48:41 PDT
Comment on attachment 60803 [details] Patch Clearing flags on attachment: 60803 Committed r62891: <http://trac.webkit.org/changeset/62891>
Comment 8 WebKit Commit Bot 2010-07-08 21:48:45 PDT
All reviewed patches have been landed. Closing bug.