Bug 41778

Summary: Add reverseFind to Vector and deploy in HTML5 parser
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41123    
Attachments:
Description Flags
Patch sam: review+, abarth: commit-queue+

Adam Barth
Reported 2010-07-07 11:09:15 PDT
Add reverseFind to Vector and deploy in HTML5 parser
Attachments
Patch (6.19 KB, patch)
2010-07-07 11:13 PDT, Adam Barth 		sam: review+
abarth: commit-queue+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-07-07 11:13:17 PDT
Created attachment 60757 [details] Patch
Adam Barth
Comment 2 2010-07-07 12:02:30 PDT
Comment on attachment 60757 [details] Patch Thanks Sam.
Eric Seidel (no email)
Comment 3 2010-07-07 13:11:18 PDT
Comment on attachment 60757 [details] Patch Huh? I don't understand your comparison change. How is it possible for find to work with a non-entity type? What was the speedup of changing the operator? I guess none, since it was already avoiding the operator in findIndex.
Adam Barth
Comment 4 2010-07-07 14:21:20 PDT
Committed r62697: <http://trac.webkit.org/changeset/62697>
Adam Barth
Comment 5 2010-07-07 15:38:04 PDT
I discussed this with Eric on the phone and he's on board now.
Note You need to log in before you can comment on or make changes to this bug.