Bug 41760

Summary:

Web Inspector: '?' typed in Search field causes shortcuts help to appear

Product:

WebKit

Reporter:

Andrey Kosyakov <caseq>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, pfeldman, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	yurys: review+, commit-queue: commit-queue-
patch	pfeldman: review+, pfeldman: commit-queue-
patch	none

Andrey Kosyakov

Reported 2010-07-07 05:25:05 PDT

0. Open Inspector 1. Navigate to search field 2. Type '?" EXPECTED: '?" appears in the search field. ACTUAL: Shortcuts help pops up.

Attachments
patch (1.60 KB, patch) 2010-07-07 05:36 PDT, Andrey Kosyakov	yurys: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
patch (1.57 KB, patch) 2010-07-08 01:35 PDT, Andrey Kosyakov	pfeldman: review+ pfeldman: commit-queue-	Details Formatted Diff Diff
patch (1.58 KB, patch) 2010-07-08 01:39 PDT, Andrey Kosyakov	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Andrey Kosyakov

Comment 1 2010-07-07 05:36:12 PDT

Created attachment 60721 [details] patch

WebKit Commit Bot

Comment 2 2010-07-07 21:54:15 PDT

Comment on attachment 60721 [details] patch Rejecting patch 60721 from commit-queue. Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1 Last 500 characters of output: mitting to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/inspector.js A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output: svnlook: Can't write to stream: Broken pipe The following ChangeLog files contain OOPS: trunk/WebCore/ChangeLog Please don't ever say "OOPS" in a ChangeLog file. at /usr/local/git/libexec/git-core/git-svn line 570 Full output: http://webkit-commit-queue.appspot.com/results/3431011

Andrey Kosyakov

Comment 3 2010-07-08 01:35:34 PDT

Created attachment 60852 [details] patch

Pavel Feldman

Comment 4 2010-07-08 01:37:45 PDT

Comment on attachment 60852 [details] patch WebCore/ChangeLog:5 + Do not invoke shortcuts popup upon bare '?' if it's typed Nit: mind Web Inspector: prefix.

Andrey Kosyakov

Comment 5 2010-07-08 01:39:17 PDT

Created attachment 60853 [details] patch

WebKit Commit Bot

Comment 6 2010-07-08 05:25:47 PDT

Comment on attachment 60853 [details] patch Clearing flags on attachment: 60853 Committed r62781: <http://trac.webkit.org/changeset/62781>

WebKit Commit Bot

Comment 7 2010-07-08 05:25:54 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.